[FEATURE](app): hide direct install and uninstall when bootloader is locked

[LindaFerum]

I've created similar request on vanilla magisk topjohnwu#9842 but chances of it being picked up there are extremely low.

Long story short, on a "magisked Graphene" with locked bootloader (like rooted graphene and pixene) and indeed any other ROM that chooses to combine locked bootloader with magisk based root the persistent presence of "install" button for ramdisk/image patching in UI presents a small but persistent threat of softbrick

A "failure of thought" / habitual action on behalf of user while presumably low probability (we're all very professionals and very cautious and careful all the time right ;-) ) can, thanks to this UI element, create a substantial amount of trouble

it is also completely unnecessary because the update of ramdisk is happening via ROM/OTA mechanisms

Thus it would be nice if the app could check if its in a locked bootloader environment (which should be very doable with root) and hide that button as well as all attendant ramdisk/boot.img update functionality so as to exclude possibility of distracted/confused user tapping themselves into a softbrick

[pixincreate]

hey, this is a very well thought ux change.

so the idea is:

• keep "patch image file"
• hide/disable direct install style flows when bootloader is locked

mainly to avoid accidental active boot image modification on setups that rely on their own ota/update handling.

that makes sense.

i think i'll make this change real soon.

[LindaFerum]

@pixincreate upon some thought I think maybe also hide/disable the "patch image file" as well as "direct install style flows " when bootloader is locked?
They both are not particularly useful on a bootloader-locked system where magisk updates are done via OTA

[pixincreate]

no, it is still useful to have the option to patch an image file since it is non-destructive and also, it gives you an option to patch the image when needed. so yeah, i would want to have that option open.

[LindaFerum]

@pixincreate OK )

[LindaFerum]

@pixincreate one more thing - Magisk features a big red Uninstall Magisk button ( I somehow totally forgot about it and got reminded just now while re-reading avbroot readme for "reasons" ;-) )
the uninstall magisk flow also would softbrick a signed-bootloader magisk system, so maybe hide that one too on signed-bootloader system?

[pixincreate]

hey @LindaFerum, if time permits, can you try the build produced by this ci run and let me know if that works as expected?

also, check this pr description for changes

[LindaFerum]

Awesome thank you very much @pixincreate , I am communicating with a guy who is planning (sorta) to make his own fork of PixeneOS with some bells and whistles added, I'll ask him to build this and test on his test phone
Will probably get it flashed and tested sooner than I can get around to this (busybusiness ... )

[pixincreate]

sure. i'll not merge the pr till then.

[SimplePasserby]

Hi @pixincreate , I'm that guy. Plan is actually to make a fork of your wonderful PixeneOS with a few of my own additions (an intetceptor app that returns docs UI instead of Google's useless but secure photopicker and some other bells and whistles and am a bit over my head 😅)
But first things first - how do I grab a magisk .apk out of those build artifacts? I did click on the link but now I am very confused , please pardon my ignorance

[pixincreate]

https://github.com/pixincreate/Magisk/actions/runs/26752414583?pr=29

try this.

download the artifact from here (you need to be logged in)

extract the zip, you'll get the apk