Server crash

[Alulom]

I use PlasmoVoice + pv-addon-groups latest versions

server crashes on some malicious packets from player

[10:57:31] [Server thread/WARN]: [PlasmoVoice] Plugin PlasmoVoice v2.1.8 generated an exception whilst handling plugin message
java.lang.IllegalStateException: java.io.EOFException
at com.google.common.io.ByteStreams$ByteArrayDataInputStream.readLong(ByteStreams.java:437) ~[guava-33.3.1-jre.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.packets.PacketUtil.readUUID(PacketUtil.java:42) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.data.player.VoicePlayerInfo.deserialize(VoicePlayerInfo.java:31) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.packets.tcp.clientbound.PlayerListPacket.read(PlayerListPacket.java:33) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.packets.tcp.PacketTcpCodec.decode(PacketTcpCodec.java:98) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.server.connection.ServerChannelHandler.receive(ServerChannelHandler.java:49) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.slib.spigot.channel.SpigotChannelManager.onPluginMessageReceived(SpigotChannelManager.kt:55) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at org.bukkit.plugin.messaging.StandardMessenger.dispatchIncomingMessage(StandardMessenger.java:484) ~[pufferfish-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at net.minecraft.server.network.ServerCommonPacketListenerImpl.handleCustomPayload(ServerCommonPacketListenerImpl.java:186) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.network.ServerGamePacketListenerImpl.handleCustomPayload(ServerGamePacketListenerImpl.java:3606) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.protocol.common.ServerboundCustomPayloadPacket.handle(ServerboundCustomPayloadPacket.java:28) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.protocol.common.ServerboundCustomPayloadPacket.handle(ServerboundCustomPayloadPacket.java:13) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.PacketProcessor$ListenerAndPacket.handle(PacketProcessor.java:99) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.PacketProcessor.executeSinglePacket(PacketProcessor.java:33) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.MinecraftServer.runAllTasksAtTickStart(MinecraftServer.java:1186) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1339) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:386) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.io.EOFException
at java.base/java.io.DataInputStream.readFully(DataInputStream.java:210) ~[?:?]
at java.base/java.io.DataInputStream.readLong(DataInputStream.java:407) ~[?:?]
at com.google.common.io.ByteStreams$ByteArrayDataInputStream.readLong(ByteStreams.java:435) ~[guava-33.3.1-jre.jar:?]
... 17 more
[10:57:33] [Paper Watchdog Thread/ERROR]: The server has not responded for 10 seconds! Creating thread dump
[10:57:33] [Paper Watchdog Thread/ERROR]: ------------------------------
[10:57:33] [Paper Watchdog Thread/ERROR]: Server thread dump (Look for plugins here before reporting to Paper!):
[10:57:33] [Paper Watchdog Thread/ERROR]: ------------------------------
[10:57:33] [Paper Watchdog Thread/ERROR]: Current Thread: Server thread
[10:57:33] [Server thread/WARN]: [PlasmoVoice] Plugin PlasmoVoice v2.1.8 generated an exception whilst handling plugin message
java.lang.IllegalStateException: java.io.EOFException
at com.google.common.io.ByteStreams$ByteArrayDataInputStream.readLong(ByteStreams.java:437) ~[guava-33.3.1-jre.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.packets.PacketUtil.readUUID(PacketUtil.java:42) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.data.player.VoicePlayerInfo.deserialize(VoicePlayerInfo.java:31) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.packets.tcp.clientbound.PlayerListPacket.read(PlayerListPacket.java:33) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.packets.tcp.PacketTcpCodec.decode(PacketTcpCodec.java:98) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.server.connection.ServerChannelHandler.receive(ServerChannelHandler.java:49) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.slib.spigot.channel.SpigotChannelManager.onPluginMessageReceived(SpigotChannelManager.kt:55) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at org.bukkit.plugin.messaging.StandardMessenger.dispatchIncomingMessage(StandardMessenger.java:484) ~[pufferfish-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at net.minecraft.server.network.ServerCommonPacketListenerImpl.handleCustomPayload(ServerCommonPacketListenerImpl.java:186) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.network.ServerGamePacketListenerImpl.handleCustomPayload(ServerGamePacketListenerImpl.java:3606) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.protocol.common.ServerboundCustomPayloadPacket.handle(ServerboundCustomPayloadPacket.java:28) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.protocol.common.ServerboundCustomPayloadPacket.handle(ServerboundCustomPayloadPacket.java:13) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.PacketProcessor$ListenerAndPacket.handle(PacketProcessor.java:99) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.PacketProcessor.executeSinglePacket(PacketProcessor.java:33) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.MinecraftServer.runAllTasksAtTickStart(MinecraftServer.java:1186) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1339) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:386) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.io.EOFException
at java.base/java.io.DataInputStream.readFully(DataInputStream.java:210) ~[?:?]
at java.base/java.io.DataInputStream.readLong(DataInputStream.java:407) ~[?:?]
at com.google.common.io.ByteStreams$ByteArrayDataInputStream.readLong(ByteStreams.java:435) ~[guava-33.3.1-jre.jar:?]
... 17 more
[10:57:35] [Paper Watchdog Thread/ERROR]: PID: 54 | Suspended: false | Native: false | State: RUNNABLE
[10:57:35] [Paper Watchdog Thread/ERROR]: Stack:
[10:57:35] [Paper Watchdog Thread/ERROR]: java.base@21.0.9/java.util.ArrayList.(ArrayList.java:156)
[10:57:35] [Paper Watchdog Thread/ERROR]: PlasmoVoice-Paper-2.1.8.jar//su.plo.voice.proto.packets.tcp.clientbound.PlayerListPacket.read(PlayerListPacket.java:29)
[10:57:35] [Paper Watchdog Thread/ERROR]: PlasmoVoice-Paper-2.1.8.jar//su.plo.voice.proto.packets.tcp.PacketTcpCodec.decode(PacketTcpCodec.java:98)
[10:57:35] [Paper Watchdog Thread/ERROR]: PlasmoVoice-Paper-2.1.8.jar//su.plo.voice.server.connection.ServerChannelHandler.receive(ServerChannelHandler.java:49)
[10:57:35] [Paper Watchdog Thread/ERROR]: PlasmoVoice-Paper-2.1.8.jar//su.plo.slib.spigot.channel.SpigotChannelManager.onPluginMessageReceived(SpigotChannelManager.kt:55)
[10:57:35] [Paper Watchdog Thread/ERROR]: org.bukkit.plugin.messaging.StandardMessenger.dispatchIncomingMessage(StandardMessenger.java:484)
[10:57:35] [Paper Watchdog Thread/ERROR]: net.minecraft.server.network.ServerCommonPacketListenerImpl.handleCustomPayload(ServerCommonPacketListenerImpl.java:186)
[10:57:35] [Paper Watchdog Thread/ERROR]: net.minecraft.server.network.ServerGamePacketListenerImpl.handleCustomPayload(ServerGamePacketListenerImpl.java:3606)
[10:57:35] [Paper Watchdog Thread/ERROR]: net.minecraft.network.protocol.common.ServerboundCustomPayloadPacket.handle(ServerboundCustomPayloadPacket.java:28)
[10:57:35] [Paper Watchdog Thread/ERROR]: net.minecraft.network.protocol.common.ServerboundCustomPayloadPacket.handle(ServerboundCustomPayloadPacket.java:13)
[10:57:35] [Paper Watchdog Thread/ERROR]: net.minecraft.network.PacketProcessor$ListenerAndPacket.handle(PacketProcessor.java:99)
[10:57:35] [Paper Watchdog Thread/ERROR]: net.minecraft.network.PacketProcessor.executeSinglePacket(PacketProcessor.java:33)
[10:57:35] [Paper Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer.runAllTasksAtTickStart(MinecraftServer.java:1186)
[10:57:35] [Paper Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1339)
[10:57:35] [Paper Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:386)
[10:57:35] [Paper Watchdog Thread/ERROR]: net.minecraft.server.MinecraftServer$$Lambda/0x0000774f60fd59a8.run(Unknown Source)
[10:57:35] [Paper Watchdog Thread/ERROR]: java.base@21.0.9/java.lang.Thread.runWith(Thread.java:1596)
[10:57:35] [Paper Watchdog Thread/ERROR]: java.base@21.0.9/java.lang.Thread.run(Thread.java:1583)
[10:57:35] [Paper Watchdog Thread/ERROR]: ------------------------------
[10:57:35] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH ---
[10:57:35] [Paper Watchdog Thread/ERROR]: ------------------------------
[10:57:35] [Server thread/WARN]: [PlasmoVoice] Plugin PlasmoVoice v2.1.8 generated an exception whilst handling plugin message
java.lang.IllegalStateException: java.io.EOFException
at com.google.common.io.ByteStreams$ByteArrayDataInputStream.readLong(ByteStreams.java:437) ~[guava-33.3.1-jre.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.packets.PacketUtil.readUUID(PacketUtil.java:42) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.data.player.VoicePlayerInfo.deserialize(VoicePlayerInfo.java:31) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.packets.tcp.clientbound.PlayerListPacket.read(PlayerListPacket.java:33) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.proto.packets.tcp.PacketTcpCodec.decode(PacketTcpCodec.java:98) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.voice.server.connection.ServerChannelHandler.receive(ServerChannelHandler.java:49) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at PlasmoVoice-Paper-2.1.8.jar/su.plo.slib.spigot.channel.SpigotChannelManager.onPluginMessageReceived(SpigotChannelManager.kt:55) ~[PlasmoVoice-Paper-2.1.8.jar:?]
at org.bukkit.plugin.messaging.StandardMessenger.dispatchIncomingMessage(StandardMessenger.java:484) ~[pufferfish-api-1.21.10-R0.1-SNAPSHOT.jar:?]
at net.minecraft.server.network.ServerCommonPacketListenerImpl.handleCustomPayload(ServerCommonPacketListenerImpl.java:186) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.network.ServerGamePacketListenerImpl.handleCustomPayload(ServerGamePacketListenerImpl.java:3606) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.protocol.common.ServerboundCustomPayloadPacket.handle(ServerboundCustomPayloadPacket.java:28) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.protocol.common.ServerboundCustomPayloadPacket.handle(ServerboundCustomPayloadPacket.java:13) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.PacketProcessor$ListenerAndPacket.handle(PacketProcessor.java:99) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.network.PacketProcessor.executeSinglePacket(PacketProcessor.java:33) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.MinecraftServer.runAllTasksAtTickStart(MinecraftServer.java:1186) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1339) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:386) ~[pufferfish-1.21.10.jar:1.21.10-39-b98b265]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.io.EOFException
at java.base/java.io.DataInputStream.readFully(DataInputStream.java:210) ~[?:?]
at java.base/java.io.DataInputStream.readLong(DataInputStream.java:407) ~[?:?]
at com.google.common.io.ByteStreams$ByteArrayDataInputStream.readLong(ByteStreams.java:435) ~[guava-33.3.1-jre.jar:?]
... 17 more

[apehum]

Thanks for the report!

Some packets were missing safety checks causing too much allocations by malicious payloads on decode causing crash.
I've added missing safety checks and fixed client packets being read on server.
Build with fixes available here: https://github.com/plasmoapp/plasmo-voice/releases/tag/2.1.9-SNAPSHOT.