From 0a7b32b22919337cca7fa3c80008d8a16ab50f7b Mon Sep 17 00:00:00 2001
From: Jeroen Soeters <wfhsoeters@gmail.com>
Date: Fri, 15 May 2026 15:43:09 -0700
Subject: [PATCH] build: bundle the atlas CLI binary alongside the formae
 installer
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

formae-plugin-atlas (and any future plugin that wraps atlas's CLI
surface) shells out to the `atlas` binary at runtime via
ariga.io/atlas-go-sdk/atlasexec, discovering it through exec.LookPath.
Today operators have to install atlas themselves on every agent host —
the hub does it via `curl -sSf https://atlasgo.sh | sh` in its custom
Dockerfile, but every other consumer of the plugin reinvents that step.

This change mirrors the pkl-reader-helm pattern (already used by the
k8s plugin): pin a version, install the binary into the repo root on
`make build`, and ship it in dist/pel/bin/ via `pkg-bin` so the formae
installer drops it next to the formae binary on \$INSTALL_DIR/bin.

ATLAS_VERSION defaults to "latest" because release.ariga.io currently
only serves a `latest` URL — once Ariga exposes versioned paths
(e.g. .../atlas-linux-amd64-v0.39.1) switch the default to a real semver
pin. The install script supports platform detection for darwin/linux
amd64/arm64.
---
 Makefile                 | 19 +++++++-
 scripts/install-atlas.sh | 93 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 111 insertions(+), 1 deletion(-)
 create mode 100755 scripts/install-atlas.sh

diff --git a/Makefile b/Makefile
index 25334693b..e07909df2 100644
--- a/Makefile
+++ b/Makefile
@@ -25,18 +25,26 @@ CHANNEL := $(shell echo "$(RAW_VERSION)" | grep -q -- '-' && echo dev || echo st
 # Override per-build with HELM_READER_VERSION=<ver>.
 HELM_READER_VERSION ?= 0.1.2
 
+# Pinned atlas CLI version. Required at runtime by plugins that wrap
+# atlas's CLI surface (today: formae-plugin-atlas via the atlas-go-sdk).
+# Currently "latest" because release.ariga.io only serves a `latest`
+# URL; switch to a real semver pin once Ariga exposes versioned paths.
+# Override per-build with ATLAS_VERSION=<ver>.
+ATLAS_VERSION ?= latest
+
 clean:
 	rm -rf .out/
 	rm -rf dist/
 	rm -rf formae
 	rm -rf fcfg
 	rm -rf pkl-reader-helm
+	rm -rf atlas
 	rm -rf version.semver
 
 clean-pel:
 	rm -rf ~/.pel/*
 
-build: helm-reader
+build: helm-reader atlas-cli
 	go build -ldflags="-X 'github.com/platform-engineering-labs/formae.Version=${VERSION}'" -o formae cmd/formae/main.go
 	go build -o fcfg cmd/formae-config/main.go
 
@@ -50,6 +58,14 @@ build: helm-reader
 helm-reader:
 	@HELM_READER_VERSION=$(HELM_READER_VERSION) ./scripts/install-helm-reader.sh
 
+## atlas-cli: Download the pinned atlas CLI binary into the repo root
+## so `build` ships it next to the formae binary and `pkg-bin` includes
+## it in dist/pel/bin/. Required at runtime by plugins that wrap atlas
+## (today: formae-plugin-atlas, which uses ariga.io/atlas-go-sdk/atlasexec
+## and discovers the binary via exec.LookPath).
+atlas-cli:
+	@ATLAS_VERSION=$(ATLAS_VERSION) ./scripts/install-atlas.sh
+
 ## install-gremlins: Install the gremlins mutation testing tool
 install-gremlins:
 	go install github.com/go-gremlins/gremlins/cmd/gremlins@latest
@@ -64,6 +80,7 @@ pkg-bin: clean build
 	cp -Rp ./formae ./dist/pel/bin
 	cp -Rp ./fcfg ./dist/pel/bin
 	cp -Rp ./pkl-reader-helm ./dist/pel/bin
+	cp -Rp ./atlas ./dist/pel/bin
 
 gen-pkl:
 	echo '${VERSION}' > ./version.semver
diff --git a/scripts/install-atlas.sh b/scripts/install-atlas.sh
new file mode 100755
index 000000000..daf91c33d
--- /dev/null
+++ b/scripts/install-atlas.sh
@@ -0,0 +1,93 @@
+#!/usr/bin/env bash
+# © 2026 Platform Engineering Labs Inc.
+#
+# SPDX-License-Identifier: FSL-1.1-ALv2
+#
+# install-atlas.sh — download a pinned atlas CLI binary into the formae
+# repo root so `make build` ships it next to the formae binary and
+# `pkg-bin` includes it in dist/pel/bin/. The atlas binary is required
+# at runtime by formae-plugin-atlas (and any future plugin that wraps
+# atlas's CLI surface); the plugin discovers it via exec.LookPath, so
+# bundling it next to the formae binary keeps the installed tree
+# self-contained.
+#
+# Pin policy: ATLAS_VERSION env var. Default is "latest" because
+# release.ariga.io currently only serves a `latest` URL — once Ariga
+# exposes per-version URLs (e.g. .../atlas-linux-amd64-v0.39.1) switch
+# this to a real semver pin.
+#
+# Output: ./atlas (chmod 755). Re-running with a real version pin is a
+# no-op when the binary's `version` subcommand already reports that pin;
+# with `latest` we always re-download.
+#
+# Usage:
+#   scripts/install-atlas.sh                # use the default pin
+#   ATLAS_VERSION=v0.39.1 scripts/install-atlas.sh
+
+set -euo pipefail
+
+# Resolve repo root from this script's location so the target works
+# regardless of the caller's CWD.
+SCRIPT_DIR=$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)
+REPO_ROOT=$(cd -- "$SCRIPT_DIR/.." && pwd)
+
+# release.ariga.io currently only resolves "latest"; specific versions
+# are not served at well-known paths today. Once Ariga exposes
+# per-version URLs, switch DEFAULT_VERSION to a real semver pin.
+DEFAULT_VERSION="latest"
+VERSION=${ATLAS_VERSION:-$DEFAULT_VERSION}
+
+TARGET="$REPO_ROOT/atlas"
+
+# Map the running platform to the atlas release asset name.
+case "$(uname -s)-$(uname -m)" in
+  Darwin-x86_64)              ASSET="atlas-darwin-amd64-${VERSION}" ;;
+  Darwin-arm64)               ASSET="atlas-darwin-arm64-${VERSION}" ;;
+  Linux-x86_64)               ASSET="atlas-linux-amd64-${VERSION}" ;;
+  Linux-aarch64|Linux-arm64)  ASSET="atlas-linux-arm64-${VERSION}" ;;
+  *)
+    echo "install-atlas: unsupported platform $(uname -s)-$(uname -m)" >&2
+    exit 1
+    ;;
+esac
+
+URL="https://release.ariga.io/atlas/${ASSET}"
+
+# Idempotency: for a real version pin, skip the download when the
+# existing binary already reports that version. The atlas binary prints
+# its version on the first line of `atlas version` (e.g. "atlas version v0.39.1").
+# With VERSION=latest there's no useful idempotency check (the upstream
+# binary can change at any time), so always re-download.
+if [[ "$VERSION" != "latest" && -x "$TARGET" ]]; then
+  if existing_version=$("$TARGET" version 2>/dev/null | head -1 | awk '{print $2}'); then
+    if [[ "$existing_version" == "$VERSION" || "v$existing_version" == "$VERSION" ]]; then
+      echo "install-atlas: atlas @ $VERSION already present"
+      exit 0
+    fi
+    if [[ -n "$existing_version" ]]; then
+      echo "install-atlas: replacing $existing_version -> $VERSION"
+    fi
+  fi
+fi
+if [[ "$VERSION" == "latest" && -x "$TARGET" ]]; then
+  echo "install-atlas: atlas present (latest pin; not re-downloading — set ATLAS_VERSION to force)"
+  exit 0
+fi
+
+# Download to a sibling temp file and rename atomically. Avoids leaving
+# a half-written `atlas` behind if the user Ctrl-Cs mid-curl.
+TMP=$(mktemp "$REPO_ROOT/.atlas.XXXXXX")
+trap 'rm -f "$TMP"' EXIT
+
+echo "install-atlas: downloading $URL"
+if ! curl -fsSL "$URL" -o "$TMP"; then
+  echo "install-atlas: download failed" >&2
+  exit 1
+fi
+
+chmod 755 "$TMP"
+mv "$TMP" "$TARGET"
+trap - EXIT
+
+echo "install-atlas: installed $TARGET"
+"$TARGET" version 2>/dev/null | head -1 || true