Skip to content

Teach Pip a few more of poker's folk names for starting hands #56

Description

@pip-robot

When you are dealt a hand with a folk name, Pip whispers it at the table: Big Slick, Snowmen, The Hammer. It is there to teach the culture of the game quietly, without a tutorial. The list lives in NICKNAMES in src/config/handNames.ts and there are 32 today.

There is room for more.

The task

Add a handful of entries to NICKNAMES. Three rules, and the first is the one that matters:

  1. Only genuinely established names. These are folk names that poker players actually use, not ones we make up. If you cannot find it in more than one place that is not a Pip page, leave it out. Say in your PR where you found each one.
  2. Key format. High rank first for non-pairs (K9, never 9K), or it will never resolve. Add an s or o suffix only when the name belongs to one variant, the way 72o is The Hammer and suited 7-2 is not.
  3. Match the register. Read docs/brand.md. These are dry and affectionate, never a punchline with an exclamation mark.

One thing that will bite you

tests/handNames.test.ts asserts that 9-4 and A-3 have no name, because "most hands have no name" is part of the point. If you add either, that test fails on purpose. Pick different hands rather than changing the test, and if you think one of those two genuinely has an established name, make that argument in the PR instead.

Getting started

pnpm install
pnpm test:all

The file is short and the whole change is config, so there is no logic to follow. Read the existing entries first: the list is curated, and one weak addition is worse than none.

Done when

pnpm test:all passes, every name you added is real and sourced in the PR body, and the keys are in high-rank-first form.

New here? See CONTRIBUTING.md. Merged work puts your name on playpip.io/credits.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    contentWriting, copy, and character contentgood first issueGood for newcomershelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions