You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Decide singular/plural spelling before adding aliases. Current repo/docs use project_payload.py; the idea was phrased as project_payloads.py / project_payloads.
If implemented, preserve the existing .py entry points as compatibility
aliases unless a deliberate breaking-release plan says otherwise.
Payload input naming
Revisit project_payload.py --input ...bim / --input ...pvar. For payload
projection, a .bim or .pvar path is being used as a PLINK payload prefix
locator, which reads strangely because the actual payload is the file set
(.bed/.bim/.fam or .pgen/.pvar/.psam).
Same issue exists in the underlying apply tools: apply_vmap_to_bfile.py and apply_vmap_to_pfile.py.
Possible direction: expose payload-prefix terminology at the wrapper level
while keeping compatibility with existing --input / --source-prefix
flags.
derived_from contract
Tighten the normative contract for derived_from in .vmap metadata.
Consider allowing project_payload.py --input to be omitted when the source
payload path can be resolved from the mapping object's derived_from.
Sumstats are trickier because payload resolution may require both raw input
and metadata. Consider whether derived_from should be a copyable single
string encoding a pair such as input=<path>;metadata=<path>, or whether the
object metadata should use structured fields.
Clarify how derived_from propagates through preparation, sharded
preparation, matching, intersection, and projection.
Combined sumstats prepare/project wrapper
Consider a wrapper for the common summary-statistics sequence: prepare_variants.py followed by project_payload.py.
Optional --target could constrain between prepare and project:
prepare raw sumstats -> optionally match/intersect to target -> project
cleaned or raw sumstats output.
Define whether this is only a convenience wrapper around existing retained
artifacts or whether it owns its own retained intermediate namespace, --resume, and --force behavior.
CLI syntax refinements
.pysuffix and with the inputformat as a subcommand:
project_payload.py --input-format bfile ...->project_payload bfile ...prepare_variants.py --input-format bim ...->prepare_variants bim ...prepare_variants_sharded.py.project_payload.py; the idea was phrased asproject_payloads.py/project_payloads..pyentry points as compatibilityaliases unless a deliberate breaking-release plan says otherwise.
Payload input naming
project_payload.py --input ...bim/--input ...pvar. For payloadprojection, a
.bimor.pvarpath is being used as a PLINK payload prefixlocator, which reads strangely because the actual payload is the file set
(
.bed/.bim/.famor.pgen/.pvar/.psam).apply_vmap_to_bfile.pyandapply_vmap_to_pfile.py.while keeping compatibility with existing
--input/--source-prefixflags.
derived_fromcontractderived_fromin.vmapmetadata.project_payload.py --inputto be omitted when the sourcepayload path can be resolved from the mapping object's
derived_from.and metadata. Consider whether
derived_fromshould be a copyable singlestring encoding a pair such as
input=<path>;metadata=<path>, or whether theobject metadata should use structured fields.
derived_frompropagates through preparation, shardedpreparation, matching, intersection, and projection.
Combined sumstats prepare/project wrapper
prepare_variants.pyfollowed byproject_payload.py.--targetcould constrain between prepare and project:prepare raw sumstats -> optionally match/intersect to target -> project
cleaned or raw sumstats output.
artifacts or whether it owns its own retained intermediate namespace,
--resume, and--forcebehavior.