From 0ad511179bebbafaef84f410925621b4cd8c9ebb Mon Sep 17 00:00:00 2001
From: Jack Felke <jrinnfelke@gmail.com>
Date: Thu, 12 Mar 2026 12:16:10 -0700
Subject: [PATCH] fix: what_changed tool passes shell operators to execFileSync

The run() helper uses execFileSync (no shell), so shell operators
like 2>/dev/null and || were being passed as literal git args,
causing incorrect results. Replace with proper array-based calls
and reuse existing getDiffFiles() helper which already handles
fallback logic.
---
 src/tools/what-changed.ts | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/tools/what-changed.ts b/src/tools/what-changed.ts
index 913dfa2..3dbcbd3 100644
--- a/src/tools/what-changed.ts
+++ b/src/tools/what-changed.ts
@@ -1,6 +1,6 @@
 import { z } from "zod";
 import type { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
-import { run, getBranch, getDiffStat } from "../lib/git.js";
+import { run, getBranch, getDiffFiles, getDiffStat } from "../lib/git.js";
 
 export function registerWhatChanged(server: McpServer): void {
   server.tool(
@@ -12,13 +12,14 @@ export function registerWhatChanged(server: McpServer): void {
     async ({ since }) => {
       const ref = since || "HEAD~5";
       const diffStat = getDiffStat(ref);
-      const diffFiles = run(`git diff ${ref} --name-only 2>/dev/null || git diff HEAD~3 --name-only`);
-      const log = run(`git log ${ref}..HEAD --oneline 2>/dev/null || git log -5 --oneline`);
+      const diffFiles = getDiffFiles(ref);
+      const log = run(["log", `${ref}..HEAD`, "--oneline"]);
+      const commitLog = log.startsWith("[") ? run(["log", "-5", "--oneline"]) : log;
       const branch = getBranch();
 
       const fileList = diffFiles.split("\n").filter(Boolean);
       const fileCount = fileList.length;
-      const commitCount = log.split("\n").filter(Boolean).length;
+      const commitCount = commitLog.split("\n").filter(Boolean).length;
 
       return {
         content: [{
@@ -29,7 +30,7 @@ Branch: ${branch}
 
 ### Commits
 \`\`\`
-${log || "no commits in range"}
+${commitLog || "no commits in range"}
 \`\`\`
 
 ### Files Changed (${fileCount})