Brakeman is slow when you have a lot of files in /storage

[poloniculmov]

Background

Brakeman version: 7.1.1
Rails version: 8
Ruby version: 3.3.5

Issue

Brakeman takes a long to time to scan for templates. We have a lot of active_storage attachments in storage, I've tried using --exclude-files that was added in #1925, but it doesn't work since the pattern for templates is ** instead of .. I'm running this on a i7 with 32GB of RAM, running Ubuntu LTS.

Other Error

Run Brakeman with --debug to see the full stack trace.

Stack trace:

✗ brakeman -d --faster --skip-files /storage/
[Notice] Using Prism parser
Loading scanner...
Processing application in /home/alexandrun/projects/z
Processing gems...                      
[Notice] Using Prism parser
Parsing Gemfile
[Notice] Detected Rails 8 application
(Processing gems) Duration: 0.030632062 seconds
Processing configuration...             
[Notice] Using Prism parser
Parsing config/environment.rb
[Notice] Using Prism parser
Parsing config/application.rb
[Notice] Using Prism parser
Parsing config/environments/production.rb
[Notice] Escaping HTML by default
(Processing configuration) Duration: 0.00671982 seconds
Finding files...                        
^C
Interrupted - exiting.
<internal:dir>:411:in `glob'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman/app_tree.rb:202:in `glob_files'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman/app_tree.rb:175:in `find_paths'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman/app_tree.rb:123:in `template_paths'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman/scanner.rb:96:in `block in process'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman/scanner.rb:52:in `process_step'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman/scanner.rb:94:in `process'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman.rb:414:in `scan'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman.rb:100:in `run'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman/commandline.rb:162:in `run_brakeman'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman/commandline.rb:125:in `regular_report'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman/commandline.rb:171:in `run_report'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman/commandline.rb:35:in `run'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/lib/brakeman/commandline.rb:20:in `start'
/home/alexandrun/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/gems/brakeman-7.1.1/bin/brakeman:10:in `<top (required)>'
/home/alexandrun/.rbenv/versions/3.3.5/bin/brakeman:25:in `load'
/home/alexandrun/.rbenv/versions/3.3.5/bin/brakeman:25:in `<main>'