Skip to content
This repository was archived by the owner on Nov 23, 2018. It is now read-only.
This repository was archived by the owner on Nov 23, 2018. It is now read-only.

Unusable under JRuby + Windows #14

Description

@tom-pryor

Using RUBY_PLATFORM under JRuby always returns java therefore
this should never be used to detect the OS under JRuby.

This causes problems under Windows and JRuby because subexec detects JRuby successfully so it calls exec. However, exec then does if !(RUBY_PLATFORM =~ /win32|mswin|mingw/).nil? which is totally pointless under JRuby since RUBY_PLATFORM will always return java so it will always execute self.output = LANG=#{lang} && export $LANG && #{command} 2>&1`` regardless of the underlying OS. Executing this on Windows is going to fail instantly because it does not understand LANG=.
@gissues:{"order":40,"status":"backlog"}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions