Skip to content
This repository was archived by the owner on Nov 23, 2018. It is now read-only.
This repository was archived by the owner on Nov 23, 2018. It is now read-only.

Deprecate this gem #21

Description

@janko

This gem doesn't have a good implementation:

  • It uses sleep 0.01 for waiting for the command to finish, which is very CPU heavy and definitively not the right way (you can do the waiting with IO.pipe, as shown in this blog post)
  • It captures stdout and stderr both in the same string, which is unusable when we actually care which is which

Most-importantly, there is already an implementation of this gem in the Ruby standard library, called open3. The Open3.catpure3 does everything that this gem does, but better and with automatic Windows support and similar. It doesn't however work on JRuby, because they didn't implement it, but they're fixing it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions