The point of these constants is to abstract out the exact species, making it easier to change, and clear which values are due to it being the starter (as opposed to checks for that species for reasons unrelated to starterness).
However, their names include the species -- STARTER_PIKACHU, RIVAL_STARTER_JOLTEON, etc. This defeats the purpose. Compare them to RESTLESS_SOUL, which does not redundantly include the actual species MAROWAK.
Suggestion:
STARTER_PIKACHU -> STARTERRIVAL_STARTER_* -> RIVAL_STARTER1-3
(Compare with pokered's STARTER1-3)
The point of these constants is to abstract out the exact species, making it easier to change, and clear which values are due to it being the starter (as opposed to checks for that species for reasons unrelated to starterness).
However, their names include the species --
STARTER_PIKACHU,RIVAL_STARTER_JOLTEON, etc. This defeats the purpose. Compare them toRESTLESS_SOUL, which does not redundantly include the actual speciesMAROWAK.Suggestion:
STARTER_PIKACHU->STARTERRIVAL_STARTER_*->RIVAL_STARTER1-3(Compare with pokered's
STARTER1-3)