comment/uncomment Keybinding on Macos Sonoma French is missing!

[mrbbp]

Most appropriate sub-area of Processing 4?

Accessibility

Processing version

4.4.4

Operating system

Macos 14.7.6

Steps to reproduce this

"1. "Command +"

snippet

// Paste your code below :)

void setup() {

}

void draw() {

}

Additional context

Comment uncomment shortcut does not work on macos.
before on french keyboard comment was command +... now, the shortcut is missing!
Why?????

Would you like to work on the issue?

I'm user, not coder

[mrbbp]

it could be great to have a keybinding page to personalize shortcuts

[mrbbp]

that does not work more on macos sonoma 14.7.6 french with the Processing 4.4.7.
I prefer to go back to 4.3.1 version who have fonctional keybinding (Command + why!)

[Stefterv]

I wonder what would be a good way to reproduce this error

[SableRaf]

Go to System Settings → Keyboard → Input Sources and add French (AZERTY).

Then in the task bar you can switch between keyboard layouts.

In this case, I believe the issue was introduced in this PR: Add quick font-size change to the edit menu #1019

On a French (AZERTY) keyboard, the new key binding conflicts with the existing ⌘ = for commenting/uncommenting.

[Stefterv]

The keybindings are defined in Processings language files here:

processing4/build/shared/lib/languages/PDE.properties

Lines 51 to 69 in 275d789

	menu.edit.comment_uncomment.keystroke.macos = meta pressed SLASH
	menu.edit.comment_uncomment.keystroke.windows = ctrl pressed SLASH
	menu.edit.comment_uncomment.keystroke.linux = ctrl pressed SLASH
	menu.edit.increase_indent = → Increase Indent
	menu.edit.increase_indent.keystroke.macos = meta pressed CLOSE_BRACKET
	menu.edit.increase_indent.keystroke.windows = ctrl pressed CLOSE_BRACKET
	menu.edit.increase_indent.keystroke.linux = ctrl pressed CLOSE_BRACKET
	menu.edit.decrease_indent = ← Decrease Indent
	menu.edit.decrease_indent.keystroke.macos = meta pressed OPEN_BRACKET
	menu.edit.decrease_indent.keystroke.windows = ctrl pressed OPEN_BRACKET
	menu.edit.decrease_indent.keystroke.linux = ctrl pressed OPEN_BRACKET
	menu.edit.increase_font = Increase Font Size
	menu.edit.increase_font.keystroke.macos = meta pressed EQUALS
	menu.edit.increase_font.keystroke.windows = ctrl pressed EQUALS
	menu.edit.increase_font.keystroke.linux = ctrl pressed EQUALS
	menu.edit.decrease_font = Decrease Font Size
	menu.edit.decrease_font.keystroke.macos = meta pressed MINUS
	menu.edit.decrease_font.keystroke.windows = ctrl pressed MINUS
	menu.edit.decrease_font.keystroke.linux = ctrl pressed MINUS

So we could add new keybindings to the French translation of Processing to make sure this overlap does not occur.
@mrbbp are you using the French translation?

[Stefterv]

Actually @mrbbp you can already customise keybindings by modifying the preferences.txt with the following key

menu.edit.increase_font.keystroke=meta pressed 0 or any other key if you want

[mrbbp]

Sorry was out...
i use English version (preference language) and i've tested with french version.
Thanks for the keybinding. i'll update my pref.

[mrbbp]

Go to System Settings → Keyboard → Input Sources and add French (AZERTY).

Then in the task bar you can switch between keyboard layouts.

In this case, I believe the issue was introduced in this PR: Add quick font-size change to the edit menu #1019

On a French (AZERTY) keyboard, the new key binding conflicts with the existing ⌘ = for commenting/uncommenting.

I've added the the input source but it does not change anything. i will rewrite the keybindings in the preferences

[mrbbp]

menu.edit.increase_font.keystroke=meta pressed 0

Yes it's the good way.
i've added the line in the preferences.txt file
it resolves the issue
Thanks

[Stefterv]

Great! I added an entry to the wiki https://github.com/processing/processing4/wiki/Keybindings