Skip to content

Fix pipenv lock resolution failure and replace unmaintained check-pipfile-lock#6060

Open
djnakabaale wants to merge 3 commits into
mainfrom
fix-pipenv-lock-platformdirs
Open

Fix pipenv lock resolution failure and replace unmaintained check-pipfile-lock#6060
djnakabaale wants to merge 3 commits into
mainfrom
fix-pipenv-lock-platformdirs

Conversation

@djnakabaale
Copy link
Copy Markdown
Contributor

@djnakabaale djnakabaale commented May 13, 2026

Jira Ticket

None

Description

This change:

  • Pins platformdirs>=4.3.6 in [packages] to fix pipenv lock failure. The platformdirs==3.11.0 (via unleashclient -> fcache) conflicted with tox's requirement of platformdirs>=4.3.6.
  • Unpins tox (from ==4.26.0 to >=4.26.0). The original reason for pinning tox (cachetools conflict with google-auth) is no longer relevant.
  • Replace the unmaintained haizaar/check-pipfile-lock external hook with a local hook that runs pipenv verify, built-in consistency check.

Testing

  1. Checkout branch.
  2. Clear pre-commit cache and run lint:
    pre-commit clean
    make lint
    1. You should see Check pipenv's Pipfile.lock to be consistent with Pipfile...Passed.
  3. Verify lock file is consistent:
    pipenv verify
  4. Run the test suite to confirm no regressions:
    pipenv run tox

Note: Developers may need to run pre-commit clean once after pulling this change to clear the cached check-pipfile-lock hook environment.

Release Notes

  • proposed release note
* Fix pipenv lock resolution failure and replace unmaintained check-pipfile-lock pre-commit hook with pipenv verify

@djnakabaale djnakabaale requested review from a team as code owners May 13, 2026 22:05
@djnakabaale djnakabaale added the smoke-tests pr_check will run minimal required smokes. Used when changes hit multiple providers. label May 13, 2026
@github-actions github-actions Bot added the smokes-required Label to show that smokes tests should be run against these changes. label May 13, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Pipfile by adding platformdirs (>=4.3.6) to satisfy transitive dependencies and relaxes the version constraint for tox from a fixed version to a minimum version (>=4.26.0). I have no feedback to provide as there were no review comments to evaluate.

@djnakabaale djnakabaale marked this pull request as draft May 13, 2026 22:07
@djnakabaale djnakabaale changed the title Fix pipenv lock resolution failure caused by platformdirs version conflict Fix pipenv lock resolution failure and replace unmaintained check-pipfile-lock May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.3%. Comparing base (21b98c7) to head (f76d12f).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #6060   +/-   ##
=====================================
  Coverage   94.3%   94.3%           
=====================================
  Files        362     362           
  Lines      32004   32004           
  Branches    3516    3516           
=====================================
+ Hits       30193   30195    +2     
+ Misses      1175    1174    -1     
+ Partials     636     635    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djnakabaale djnakabaale marked this pull request as ready for review May 20, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

smoke-tests pr_check will run minimal required smokes. Used when changes hit multiple providers. smokes-required Label to show that smokes tests should be run against these changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant