Fix pipenv lock resolution failure and replace unmaintained check-pipfile-lock#6060
Open
djnakabaale wants to merge 3 commits into
Open
Fix pipenv lock resolution failure and replace unmaintained check-pipfile-lock#6060djnakabaale wants to merge 3 commits into
djnakabaale wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Pipfile by adding platformdirs (>=4.3.6) to satisfy transitive dependencies and relaxes the version constraint for tox from a fixed version to a minimum version (>=4.26.0). I have no feedback to provide as there were no review comments to evaluate.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6060 +/- ##
=====================================
Coverage 94.3% 94.3%
=====================================
Files 362 362
Lines 32004 32004
Branches 3516 3516
=====================================
+ Hits 30193 30195 +2
+ Misses 1175 1174 -1
+ Partials 636 635 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Ticket
None
Description
This change:
platformdirs>=4.3.6in[packages]to fixpipenv lockfailure. Theplatformdirs==3.11.0(viaunleashclient->fcache) conflicted withtox's requirement ofplatformdirs>=4.3.6.tox(from==4.26.0to>=4.26.0). The original reason for pinning tox (cachetools conflict with google-auth) is no longer relevant.haizaar/check-pipfile-lockexternal hook with a local hook that runspipenv verify, built-in consistency check.Testing
Check pipenv's Pipfile.lock to be consistent with Pipfile...Passed.Note: Developers may need to run
pre-commit cleanonce after pulling this change to clear the cachedcheck-pipfile-lockhook environment.Release Notes
* Fix pipenv lock resolution failure and replace unmaintained check-pipfile-lock pre-commit hook with pipenv verify