Board has no 'cancelled' terminal status — not_planned issue closes emit feature.completed

[mabry1985]

Problem

The 5-status board model (backlog → in_progress → review → done, plus blocked) has one terminal status: done. FeatureLifecycleBusPublisher emits feature.completed on any transition to done (apps/server/src/services/feature-lifecycle-bus-publisher.ts:40, TERMINAL_STATUSES = {'done'} — archived is not considered).

The issue-close-sync webhook (#4102) terminalizes a linked feature to done when its GitHub issue closes. With #4102's follow-up, the close now carries state_reason (completed vs not_planned) on the audit trail and the feature:issue-closed event — but because the status still becomes done, an issue closed as not planned (wontfix/duplicate/abandoned) still:

• emits feature.completed to protoWorkstacean (workstacean thinks it shipped), and
• counts as shipped/completed work in any board metrics keyed on done.

archiveFeature isn't a fix: it's a destructive relocate (deletes + stubs the feature dir) that still lands on status: 'done' and would break #4102's reopen-recovery path.

Proposed fix

Add a cancelled (or abandoned) terminal status to FeatureStatus, and:

• route not_planned issue closes there instead of done (feat(webhooks): auto-close the linked feature when a GitHub issue closes #4102 already plumbs state_reason to the handler + event, so the wiring point exists);
• map cancelled to a distinct lifecycle signal (e.g. feature.cancelled, or simply not feature.completed) in FeatureLifecycleBusPublisher;
• exclude cancelled from "shipped" metrics; treat it as terminal for backlog-clearing.

Acceptance

• Closing a linked GitHub issue as "not planned" terminalizes the feature without emitting feature.completed and without inflating shipped counts.
• Reopening still recovers it (parity with feat(webhooks): auto-close the linked feature when a GitHub issue closes #4102's reopened path).
• Unit coverage for completed vs not_planned close → distinct terminal status + distinct/absent lifecycle emission.

Context

Found taking over #4102 (roxy's issue-close-sync). #4102 ships the state_reason plumbing; this issue is the board-model change it sets up. Out of scope for #4102 itself (single-status terminal model is a broader change).

[github-actions]

👋 Thank you for submitting this idea!

Your issue has been added to our ideas pipeline. Here's what happens next:

1. Triage (1-3 days): Our team will review and label your idea
2. Discussion (ongoing): We may ask clarifying questions or gather community feedback
3. Acceptance (varies): If accepted, we'll add the status: accepted label
4. Implementation (varies): Our AI agents will implement accepted ideas and link the PR here

We appreciate your contribution to making this project better! 🚀

[mabry1985]

Minimal fix landed — #4106 (542e64524).

Rather than add a new cancelled board status (a ~20-file board-UX change), the core harm is solved with the existing model:

• a not_planned issue close sets done + archived: true (clears the active board, not counted as shipped)
• the lifecycle bus emits feature.cancelled (not feature.completed) for a terminal archived feature — so workstacean no longer records abandoned issues as shipped, and the completion close-the-loop doesn't fire
• the reopened path un-archives, restoring the feature to the active backlog

This meets the acceptance (no false feature.completed, not counted as shipped, reopen recovers) with unit coverage on the distinct lifecycle emission.

What's left (the reason this stays open): the literal "distinct terminal status" — a user-visible cancelled column on the board, plus DORA/metrics + normalization. That's a product/UX decision (where/how it surfaces) and is optional now that the signal-level harm is fixed. Close this if the archived representation is sufficient; keep it for the board-surfaced version.