I would simplify the add_pd_external function by reducing the number of arguments from three to two: one for the binary output name and one for the source code. Currently, the function takes three arguments: the library name, the binary output name, and the source code.
There's an issue with using the ~ character in the add_library function. We have two options to solve this:
Not allows the ~ char: FATAL_ERROR if the user set a output with the ~ character, something like: "You can't use the ~ character, replace it with _tilde."
Automatic Replacement: Automatically replace the ~ character, but this approach introduces more problems (as seen in the the test implementation in my repo's dev branch).
Current: add_pd_external(library_name, binary_output_name, source_code)
Suggested: add_pd_external(binary_output_name, source_code)
What do you think?
Originally posted by @charlesneimog in #7 (comment)
I would simplify the
add_pd_externalfunction by reducing the number of arguments from three to two: one for the binary output name and one for the source code. Currently, the function takes three arguments: the library name, the binary output name, and the source code.There's an issue with using the
~character in theadd_libraryfunction. We have two options to solve this:Not allows the
~char:FATAL_ERRORif the user set a output with the ~ character, something like: "You can't use the ~ character, replace it with _tilde."Automatic Replacement: Automatically replace the ~ character, but this approach introduces more problems (as seen in the the test implementation in my repo's dev branch).
Current:
add_pd_external(library_name, binary_output_name, source_code)Suggested:
add_pd_external(binary_output_name, source_code)What do you think?
Originally posted by @charlesneimog in #7 (comment)