Skip to content

Commit 46752ea

Browse files
committed
Arm backend: Correct buck2 files
This commit is exact suggestion that kirklandsign posted in #19969 Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com> Suggested-by: @kirklandsign Change-Id: Iacce4dd11e61e4d79296e37e59ddb214072dd2ef
1 parent 2dbad95 commit 46752ea

2 files changed

Lines changed: 15 additions & 55 deletions

File tree

backends/arm/test/BUCK

Lines changed: 13 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -49,42 +49,6 @@ fbcode_target(_kind = runtime.python_library,
4949
]
5050
)
5151

52-
fbcode_target(_kind = runtime.python_library,
53-
name = "custom_vgf_test_utils",
54-
srcs = ["_custom_vgf_test_utils.py"],
55-
resources = [
56-
"assets/test_add_buffer.glsl",
57-
"assets/test_grid_read_tensor_debug.glsl",
58-
"assets/test_grid_sample_buffer_nchw_debug.glsl",
59-
"assets/test_grid_sample_sampler.glsl",
60-
"assets/test_grid_sample_sampler_buffer_debug.glsl",
61-
"assets/test_identity_buffer.glsl",
62-
"assets/test_identity_image_packed_buffer.glsl",
63-
"assets/test_threes_buffer.glsl",
64-
"assets/test_threes_image_packed_buffer.glsl",
65-
],
66-
deps = [
67-
"//caffe2:torch",
68-
"//executorch/backends/arm:constants",
69-
"//executorch/backends/arm/_passes:passes",
70-
"//executorch/backends/arm/tosa/dialect:lib",
71-
"//executorch/exir:lib",
72-
],
73-
)
74-
75-
fbcode_target(_kind = runtime.python_library,
76-
name = "vgf_runtime_test_utils",
77-
srcs = ["runtime/_vgf_runtime_test_utils.py"],
78-
deps = [
79-
":custom_vgf_test_utils",
80-
":runner_utils",
81-
"//executorch/backends/arm:vgf",
82-
"//executorch/backends/arm/_passes:passes",
83-
"//executorch/exir:lib",
84-
"fbsource//third-party/pypi/pytest:pytest",
85-
],
86-
)
87-
8852
fbcode_target(_kind = runtime.python_library,
8953
name = "arm_tester_serialize",
9054
srcs = ["tester/serialize.py"],
@@ -120,4 +84,17 @@ fbcode_target(_kind = runtime.python_library,
12084
]
12185
)
12286

87+
fbcode_target(_kind = runtime.python_library,
88+
name = "mxfp_test_common",
89+
srcs = [
90+
"ops/mxfp/__init__.py",
91+
"ops/mxfp/common.py",
92+
],
93+
deps = [
94+
":arm_tester" if runtime.is_oss else "//executorch/backends/arm/test/tester/fb:arm_tester_fb",
95+
"//executorch/backends/arm:ao_ext",
96+
"//executorch/backends/test/harness:tester",
97+
],
98+
)
99+
123100
fbcode_target(_kind = define_arm_tests,)

backends/arm/test/targets.bzl

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ def define_arm_tests():
4343
"ops/test_gelu.py",
4444
"ops/test_bmm.py",
4545
"ops/test_split.py",
46-
"ops/test_custom_shader_lowering.py",
4746
]
4847

4948
# Quantization
@@ -63,7 +62,6 @@ def define_arm_tests():
6362
"misc/test_tosa_spec.py",
6463
"misc/test_bn_relu_folding_qat.py",
6564
"misc/test_custom_partition.py",
66-
"misc/test_custom_shader_payloads.py",
6765
"misc/test_debug_hook.py",
6866
"misc/test_mxfp_linear_ao.py",
6967
"misc/test_post_quant_device_switch.py",
@@ -73,14 +71,6 @@ def define_arm_tests():
7371
# "misc/test_dim_order.py", (TODO - T238390249)
7472
]
7573

76-
test_files += [
77-
"runtime/test_vgf_aliasing_runtime.py",
78-
"runtime/test_vgf_combinations_runtime.py",
79-
"runtime/test_vgf_multi_segment_runtime.py",
80-
"runtime/test_vgf_sampler_image_runtime.py",
81-
"runtime/test_vgf_tensor_buffer_runtime.py",
82-
]
83-
8474
# Deprecation tests
8575
test_files += [
8676
"deprecation/test_arm_compile_spec_deprecation.py",
@@ -91,16 +81,10 @@ def define_arm_tests():
9181
for test_file in test_files:
9282
test_file_name = paths.basename(test_file)
9383
test_name = test_file_name.replace("test_", "").replace(".py", "")
94-
test_srcs = [test_file]
95-
if test_file == "ops/mxfp/test_mxfp_linear.py":
96-
test_srcs += [
97-
"ops/mxfp/__init__.py",
98-
"ops/mxfp/common.py",
99-
]
10084

10185
python_pytest(
10286
name = test_name,
103-
srcs = test_srcs,
87+
srcs = [test_file],
10488
pytest_config = "pytest.ini",
10589
resources = ["conftest.py"],
10690
compile = "with-source",
@@ -124,9 +108,8 @@ def define_arm_tests():
124108
deps = [
125109
"//executorch/backends/arm/test:arm_tester" if runtime.is_oss else "//executorch/backends/arm/test/tester/fb:arm_tester_fb",
126110
"//executorch/backends/arm/test:conftest",
111+
"//executorch/backends/arm/test:mxfp_test_common",
127112
"//executorch/backends/arm/test/misc:dw_convs_shared_weights_module",
128-
"//executorch/backends/arm/test:custom_vgf_test_utils",
129-
"//executorch/backends/arm/test:vgf_runtime_test_utils",
130113
"//executorch/backends/arm:ao_ext",
131114
"//executorch/backends/arm:ethosu",
132115
"//executorch/backends/arm/tosa:compile_spec",

0 commit comments

Comments
 (0)