Update

[ghstack-poisoned]

Author: JulianCloudNTH

backends/webgpu/runtime/ops/sigmoid/UnaryOp.cpp

@@ -36,8 +36,7 @@ void sigmoid_impl(WebGPUGraph& graph, const std::vector<int>& args) {
   // 4-byte (fp32) alignment guard on both operands; also the dtype guard.
   if (in_tensor.nbytes % sizeof(float) != 0 ||
       out_tensor.nbytes % sizeof(float) != 0) {
-    throw std::runtime_error(
-        "sigmoid: operand not 4-byte aligned (expected fp32)");
+    throw std::runtime_error("sigmoid: operand not 4-byte aligned");
   }
 
   uint32_t num_elements =

backends/webgpu/runtime/ops/slice/Slice.cpp

@@ -71,6 +71,9 @@ void slice_impl(WebGPUGraph& graph, const std::vector<int>& args) {
   // Clamp start to [0, in_size] (guards the gather offset; out size is AOT).
   start = start < 0 ? 0 : (start > in_size ? in_size : start);
   const int64_t step = read_scalar(graph, args.at(4), 1, "step");
+  if (step < 1) {
+    throw std::runtime_error("slice: step must be >= 1");
+  }
 
   TensorMeta out_meta;
   TensorMeta in_meta;

backends/webgpu/runtime/ops/view_copy/ViewCopy.cpp

@@ -40,12 +40,14 @@ void add_flat_copy(WebGPUGraph& graph, int in_id, int out_id) {
 
   const auto& in_tensor = graph.get_tensor(in_id);
   const auto& out_tensor = graph.get_tensor(out_id);
+  // Flat byte copy assumes dense row-major operands; the WebGPU buffer
+  // backend only produces contiguous tensors, so a strided/transposed
+  // view cannot reach here.
 
   // 4-byte (fp32) alignment guard on both operands; also the dtype guard.
   if (in_tensor.nbytes % sizeof(float) != 0 ||
       out_tensor.nbytes % sizeof(float) != 0) {
-    throw std::runtime_error(
-        "flat_copy: operand not 4-byte aligned (expected fp32)");
+    throw std::runtime_error("flat_copy: operand not 4-byte aligned");
   }
 
   const uint32_t in_numel =

backends/webgpu/test/ops/mul/test_mul.py

@@ -7,16 +7,16 @@
 """`aten.mul.Tensor` (full broadcast) module + configs for the WebGPU op-test framework.
 
 `MulModule` + `CONFIGS` are imported by `cases.py` to drive the declarative op-test
-suite (export via VulkanPartitioner + fp64 torch golden, run on Dawn). `TestMul` is
-the export-delegation + eager-correctness smoke test. Configs span the same-shape
+suite (export via VulkanPartitioner + fp64 torch golden, run on Dawn). `MulTest` is
+the export-delegation smoke test. Configs span the same-shape
 fast path (SwiGLU), last-dim broadcast at LLM width, and a mixed-rank left-pad case.
 """
 
 import unittest
 
 import torch
 
-from executorch.backends.vulkan import VulkanPartitioner
+from executorch.backends.vulkan.partitioner.vulkan_partitioner import VulkanPartitioner
 from executorch.exir import to_edge_transform_and_lower
 
 # name -> (shape_a, shape_b). Output shape is the broadcast of the two.
@@ -55,20 +55,11 @@ def _delegated(et) -> bool:
     )
 
 
-class TestMul(unittest.TestCase):
+class MulTest(unittest.TestCase):
     def test_export_delegates(self) -> None:
         for name, (sa, sb) in CONFIGS.items():
             a, b = _det_inputs(sa, sb)
             et = _export(a, b)
             self.assertTrue(
                 _delegated(et), f"Expected a VulkanBackend delegate (mul {name})"
             )
-
-    def test_golden_matches_eager(self) -> None:
-        for _, (sa, sb) in CONFIGS.items():
-            a, b = _det_inputs(sa, sb)
-            torch.testing.assert_close(MulModule()(a, b), a * b)
-
-
-if __name__ == "__main__":
-    unittest.main()

backends/webgpu/test/ops/select/test_select.py

@@ -7,7 +7,7 @@
 """`aten.select_copy.int` module + configs for the WebGPU op-test framework.
 
 `SelectModule` + `CONFIGS` are imported by `cases.py` to drive the declarative
-op-test suite. `TestSelect` is the export-delegation + eager-correctness smoke test.
+op-test suite. `SelectTest` is the export-delegation smoke test.
 Configs cover the leading, middle, and last dim plus a negative index (output rank =
 input rank - 1).
 """
@@ -16,7 +16,7 @@
 
 import torch
 
-from executorch.backends.vulkan import VulkanPartitioner
+from executorch.backends.vulkan.partitioner.vulkan_partitioner import VulkanPartitioner
 from executorch.exir import to_edge_transform_and_lower
 
 # name -> (input_shape, select_fn)
@@ -57,19 +57,10 @@ def _delegated(et) -> bool:
     )
 
 
-class TestSelect(unittest.TestCase):
+class SelectTest(unittest.TestCase):
     def test_export_delegates(self) -> None:
         for name, (shape, fn) in CONFIGS.items():
             et = _export(fn, _det_input(shape))
             self.assertTrue(
                 _delegated(et), f"Expected a VulkanBackend delegate (select {name})"
             )
-
-    def test_golden_matches_eager(self) -> None:
-        for _, (shape, fn) in CONFIGS.items():
-            x = _det_input(shape)
-            torch.testing.assert_close(SelectModule(fn)(x), fn(x))
-
-
-if __name__ == "__main__":
-    unittest.main()

backends/webgpu/test/ops/sigmoid/test_sigmoid.py

@@ -7,7 +7,7 @@
 """`aten.sigmoid.default` module + input for the WebGPU op-test framework.
 
 `SigmoidModule`, `N`, and `_det_input` are imported by `cases.py` to drive the
-declarative op-test suite. `TestSigmoid` is the export-delegation + eager-correctness
+declarative op-test suite. `SigmoidTest` is the export-delegation
 smoke test. Sigmoid is on the Llama critical path (`F.silu` -> `sigmoid` + `mul`); the
 deterministic input spans the saturation tails.
 """
@@ -16,7 +16,7 @@
 
 import torch
 
-from executorch.backends.vulkan import VulkanPartitioner
+from executorch.backends.vulkan.partitioner.vulkan_partitioner import VulkanPartitioner
 from executorch.exir import to_edge_transform_and_lower
 
 # Input length; the deterministic input spans the saturation tails.
@@ -40,7 +40,7 @@ def _export(m: torch.nn.Module, x: torch.Tensor):
     ).to_executorch()
 
 
-class TestSigmoid(unittest.TestCase):
+class SigmoidTest(unittest.TestCase):
     def test_export_delegates(self) -> None:
         et = _export(SigmoidModule().eval(), _det_input())
         found = any(
@@ -49,11 +49,3 @@ def test_export_delegates(self) -> None:
             for d in plan.delegates
         )
         self.assertTrue(found, "Expected a VulkanBackend delegate (sigmoid)")
-
-    def test_golden_matches_eager(self) -> None:
-        x = _det_input()
-        torch.testing.assert_close(SigmoidModule()(x), torch.sigmoid(x))
-
-
-if __name__ == "__main__":
-    unittest.main()

backends/webgpu/test/ops/squeeze/test_squeeze.py

@@ -7,15 +7,15 @@
 """`aten.squeeze_copy.dims` module + configs for the WebGPU op-test framework.
 
 `SqueezeModule` + `CONFIGS` are imported by `cases.py` to drive the declarative
-op-test suite. `TestSqueeze` is the export-delegation + eager-correctness smoke
+op-test suite. `SqueezeTest` is the export-delegation smoke
 test.
 """
 
 import unittest
 
 import torch
 
-from executorch.backends.vulkan import VulkanPartitioner
+from executorch.backends.vulkan.partitioner.vulkan_partitioner import VulkanPartitioner
 from executorch.exir import to_edge_transform_and_lower
 
 # name -> (input_shape, squeeze_dim)
@@ -59,7 +59,7 @@ def _op_delegated(edge, op_substr: str) -> bool:
     return all(op_substr not in str(getattr(n, "target", "")) for n in gm.graph.nodes)
 
 
-class TestSqueeze(unittest.TestCase):
+class SqueezeTest(unittest.TestCase):
     def test_export_delegates(self) -> None:
         for name, (shape, dim) in CONFIGS.items():
             edge = _lower(dim, _det_input(shape))
@@ -72,12 +72,3 @@ def test_export_delegates(self) -> None:
                 _op_delegated(edge, "squeeze_copy"),
                 f"squeeze_copy not delegated (fell back to CPU) for {name}",
             )
-
-    def test_golden_matches_eager(self) -> None:
-        for _, (shape, dim) in CONFIGS.items():
-            x = _det_input(shape)
-            torch.testing.assert_close(SqueezeModule(dim)(x), torch.squeeze(x, dim))
-
-
-if __name__ == "__main__":
-    unittest.main()

backends/webgpu/test/ops/unsqueeze/test_unsqueeze.py

@@ -7,15 +7,15 @@
 """`aten.unsqueeze_copy.default` module + configs for the WebGPU op-test framework.
 
 `UnsqueezeModule` + `CONFIGS` are imported by `cases.py` to drive the declarative
-op-test suite. `TestUnsqueeze` is the export-delegation + eager-correctness smoke
+op-test suite. `UnsqueezeTest` is the export-delegation smoke
 test.
 """
 
 import unittest
 
 import torch
 
-from executorch.backends.vulkan import VulkanPartitioner
+from executorch.backends.vulkan.partitioner.vulkan_partitioner import VulkanPartitioner
 from executorch.exir import to_edge_transform_and_lower
 
 # name -> (input_shape, unsqueeze_dim)
@@ -59,7 +59,7 @@ def _op_delegated(edge, op_substr: str) -> bool:
     return all(op_substr not in str(getattr(n, "target", "")) for n in gm.graph.nodes)
 
 
-class TestUnsqueeze(unittest.TestCase):
+class UnsqueezeTest(unittest.TestCase):
     def test_export_delegates(self) -> None:
         for name, (shape, dim) in CONFIGS.items():
             edge = _lower(dim, _det_input(shape))
@@ -71,12 +71,3 @@ def test_export_delegates(self) -> None:
                 _op_delegated(edge, "unsqueeze_copy"),
                 f"unsqueeze_copy not delegated (fell back to CPU) for {name}",
             )
-
-    def test_golden_matches_eager(self) -> None:
-        for _, (shape, dim) in CONFIGS.items():
-            x = _det_input(shape)
-            torch.testing.assert_close(UnsqueezeModule(dim)(x), torch.unsqueeze(x, dim))
-
-
-if __name__ == "__main__":
-    unittest.main()

backends/webgpu/test/ops/view_copy/test_view_copy.py

@@ -7,15 +7,15 @@
 """`aten.view_copy.default` module + configs for the WebGPU op-test framework.
 
 `ViewModule` + `CONFIGS` are imported by `cases.py` to drive the declarative
-op-test suite. `TestViewCopy` is the export-delegation + eager-correctness
+op-test suite. `ViewCopyTest` is the export-delegation
 smoke test.
 """
 
 import unittest
 
 import torch
 
-from executorch.backends.vulkan import VulkanPartitioner
+from executorch.backends.vulkan.partitioner.vulkan_partitioner import VulkanPartitioner
 from executorch.exir import to_edge_transform_and_lower
 
 # name -> (input_shape, view_fn)
@@ -55,20 +55,11 @@ def _delegated(et) -> bool:
     )
 
 
-class TestViewCopy(unittest.TestCase):
+class ViewCopyTest(unittest.TestCase):
     def test_export_delegates(self) -> None:
         for name, (shape, fn) in CONFIGS.items():
             et = _export(fn, _det_input(shape))
             self.assertTrue(
                 _delegated(et),
                 f"Expected a VulkanBackend delegate (view_copy {name})",
             )
-
-    def test_golden_matches_eager(self) -> None:
-        for _, (shape, fn) in CONFIGS.items():
-            x = _det_input(shape)
-            torch.testing.assert_close(ViewModule(fn)(x), fn(x))
-
-
-if __name__ == "__main__":
-    unittest.main()