Skip to content

Commit d419aa8

Browse files
Gasoonjiafacebook-github-bot
authored andcommitted
Add missing evalue dep to test_cuda_mutable_state (forward fix for D108707549)
Summary: Forward fix for D108707549 (cuda: add per-session mutable state rebinding, #20241). The new `test_cuda_mutable_state` cpp_unittest fails to compile internally: test/test_cuda_mutable_state.cpp -> cuda_delegate_handle.h -> aoti_delegate_handle.h:12: fatal error: 'executorch/runtime/core/evalue.h' file not found The test includes the delegate-handle header chain, which pulls in <executorch/runtime/core/evalue.h>, but the test target's deps only list //executorch/runtime/core:core (not :evalue). cuda_backend.cpp itself compiles because it reaches evalue transitively through deps the test does not have (e.g. runtime/backend:interface, exec_aten/util:tensor_util). On GitHub the CMake build picks evalue.h up via broad include dirs, so this only surfaces in the internal Buck build. Fix: add //executorch/runtime/core:evalue to the test target's deps in both the fbcode and xplat TARGETS. Differential Revision: D108829495
1 parent 218cc45 commit d419aa8

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

backends/cuda/runtime/TARGETS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ cpp_unittest(
151151
"//executorch/backends/aoti/slim/core:slimtensor",
152152
"//executorch/backends/aoti/slim/factory:from_blob",
153153
"//executorch/runtime/core:core",
154+
"//executorch/runtime/core:evalue",
154155
"//executorch/runtime/platform:platform",
155156
],
156157
external_deps = [

0 commit comments

Comments
 (0)