Decompressed files are only deleted on Server only if they are moved

[pnuu]

Describe the bug
If file decompression is run on the Trollmoves Server, the files will always be decompressed to a working directory (/tmp by default on Linux). These decompressed files are deleted only if they have been transferred.

To Reproduce
Run a Trollmoves Server watching a directory where compressed files are arriving, and have it decompress the files.

Expected behavior
All the decompressed files should be deleted after remove_delay (by default 30 seconds) has been passed.

Actual results
The files are scheduled for deletion only if they are requested and transferred successfully. The relevant parts of trollmoves.server module are:

1. https://github.com/pytroll/trollmoves/blob/main/trollmoves/server.py#L252
   which is called from

2. trollmoves/trollmoves/server.py

   Line 230 in 2d84dbb

   error_message = self._move_file(pathname, message, rel_path)

   
   which is called from

3. trollmoves/trollmoves/server.py

   Line 213 in 2d84dbb

   new_msg = self._move_files(message)

   
   which is called from

4. trollmoves/trollmoves/server.py

   Line 354 in 2d84dbb

   Thread(target=self.reply_and_send, args=(self.push, address, message)).start()

   
   which is called from

5. trollmoves/trollmoves/server.py

   Line 327 in 2d84dbb

   self._process_request(Message(rawstr=payload), address)

   
   which is called from

6. trollmoves/trollmoves/server.py

   Line 311 in 2d84dbb

   self._run()

   
   which is called from

7. trollmoves/bin/move_it_server.py

   Line 133 in 2d84dbb

   server.run()

So due to the scheduling for deletion happening only for push messages (point 5 above), the files will remain in the working directory when there are no push requests. This can happen when

• the Client(s) are stopped/crashed
• there are multiple Servers hosting the data, so only one of the receives the push request

[pnuu]

Hmm, actually self._add_to_deleter() is present in RequestManager.ack(), but maybe it's not being accessed.