Skip to content

[6278][IMP] website_form_partner_specific_user_account: reflect oca changes#104

Merged
kanda999 merged 5 commits into
15.0from
6278-imp_website_form_partner_specific_user_account
Feb 4, 2026
Merged

[6278][IMP] website_form_partner_specific_user_account: reflect oca changes#104
kanda999 merged 5 commits into
15.0from
6278-imp_website_form_partner_specific_user_account

Conversation

@AungKoKoLin1997
Copy link
Copy Markdown
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Jan 8, 2026

@AungKoKoLin1997
Copy link
Copy Markdown
Contributor Author

AungKoKoLin1997 commented Jan 8, 2026

I realized some tests case of this module is not compatible with partner_company_default like checking False case for company when restrict_partner_to_company of website is False.

@AungKoKoLin1997
Copy link
Copy Markdown
Contributor Author

AungKoKoLin1997 commented Jan 9, 2026

I realized some tests case of this module is not compatible with partner_company_default like checking False case for company when restrict_partner_to_company of website is False.

Fixed in my last commit.

yostashiro
yostashiro reviewed Jan 9, 2026
View reviewed changes
Comment thread ..._form_partner_specific_user_account/tests/test_website_form_partner_specific_user_account.py Outdated
Comment thread ..._form_partner_specific_user_account/tests/test_website_form_partner_specific_user_account.py Outdated
Comment thread ..._form_partner_specific_user_account/tests/test_website_form_partner_specific_user_account.py Outdated
Comment thread ..._form_partner_specific_user_account/tests/test_website_form_partner_specific_user_account.py
Comment thread ..._form_partner_specific_user_account/tests/test_website_form_partner_specific_user_account.py
yostashiro
yostashiro approved these changes Jan 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AungKoKoLin1997 Thanks. Please relay the update to the OCA PR.

@AungKoKoLin1997
Copy link
Copy Markdown
Contributor Author

AungKoKoLin1997 commented Jan 29, 2026

@yostashiro There is a bug in the previous logic and I updated. Please review my last commit.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 6278-imp_website_form_partner_specific_user_account branch from d11c506 to 486d3df Compare January 29, 2026 09:22
nobuQuartile
nobuQuartile approved these changes Jan 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nobuQuartile nobuQuartile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: LGTM

nobuQuartile
nobuQuartile reviewed Jan 30, 2026
View reviewed changes
Comment thread website_form_partner_specific_user_account/controllers/main.py Outdated
nobuQuartile
nobuQuartile approved these changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nobuQuartile nobuQuartile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Code review

kanda999
kanda999 approved these changes Feb 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanda999 kanda999 merged commit 460e74a into 15.0 Feb 4, 2026
2 checks passed
yostashiro
yostashiro reviewed Feb 4, 2026
View reviewed changes
Comment thread website_form_partner_specific_user_account/controllers/main.py
if website.restrict_partner_to_company:
vals["company_id"] = website.company_id.id
website_partner = Partner.create(vals)
if website_partner:
Copy link
Copy Markdown
Member

@yostashiro yostashiro Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have removed this condition.

Copy link
Copy Markdown
Contributor Author

@AungKoKoLin1997 AungKoKoLin1997 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I will follow up this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yostashiro yostashiro yostashiro approved these changes

@kanda999 kanda999 kanda999 approved these changes

@nobuQuartile nobuQuartile nobuQuartile approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AungKoKoLin1997 @yostashiro @kanda999 @nobuQuartile