Skip to content

[Feature Request] mlp linear to conv,not use up_proj and gate_proj #310

@cuiyu1227

Description

@cuiyu1227

qai_hub_models/models/_shared/qwen3/model_adaptations.py
class QCQwen3MLP(Qwen3MLP):
def prepare_conv(self) -> None:
# TODO (https://github.com/qcom-ai-hub/tetracode/issues/17113)
# Temporarily commented out due to AISW-148745.
# self.up_proj = ConvInplaceLinear(self.up_proj) # type: ignore[has-type, arg-type, unused-ignore]
self.down_proj = ConvInplaceLinear(self.down_proj) # type: ignore[has-type, arg-type, unused-ignore]
# self.gate_proj = ConvInplaceLinear(self.gate_proj) # type: ignore[has-type, arg-type, unused-ignore]

hi,why not use self.up_proj = ConvInplaceLinear and self.gate_proj = ConvInplaceLinear.https://github.com/qcom-ai-hub/tetracode/issues/17113 could not get in.could you tell me the reason?

Metadata

Metadata

Assignees

No one assigned

    Labels

    assignedWe're actively working on this issue and hope to provide an update soonstale

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions