Skip to content

Master branch is broken after 1bd2dab ("Add fuzzy search", 2024-09-20) #223

@jsangco

Description

@jsangco

Hello,

Been trying to get the script to work and I had to back in time to before the FuzzySearch stuff was added.

The following change seems to be causing breakages:

1bd2dab ("Add fuzzy search for shows by name", 2024-09-20)

Bugs

The FuzzySearch virtual table setup is broken. I resolved it with the following change:

CREATE VIRTUAL TABLE IF NOT EXISTS FuzzySearch USING spellfix1;

There's also problems on line 531 with a missing trailing commas. The file should read:

self.q.execute"(INSERT INTO FuzzySearch (word) VALUES (?)", (name,))
self.q.execute"(INSERT INTO FuzzySearch (word) VALUES (?)", (name_en,))

Still not working

Unfortunately, even after those changes I still wasn't able to get it to work--some tables foreign key constraint was broken and I didn't have time to debug further.

I ended up going back in time to the following commit which does work:

c5d3437 ("Merge pull request #215 from Badspler/2024fall", 2024-10-28)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions