Skip to content

Improve code in wl_convert_units.hyperSpec() #70

@GegznaV

Description

@GegznaV
  • switch sentence in the wl_convert_units.hyperSpec() may be replaced with with wl_create_label_from_units(to, on_failure = "pass as-is")
Details

Basing on the lines from R/wl_convert_units.R (see this comment ), this switch sentence:

  x@label$.wavelength <-
    switch(.wl_fix_unit_name(to),
       nm    = expression("Wavelength, nm"),
      invcm = expression(tilde(nu) / cm^-1),
      ev    = expression("Energy / eV"),
      freq  = expression(nu / THz),
      raman = expression(Raman ~ shift / cm^-1),
      to
    )

Could be replaced with:

x@label$.wavelength <- wl_create_label_from_units(to, on_failure = "pass as-is")

The issue is that the default labels would change too.

Related: #69

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions