Use new roxygen2 `DESCRIPTION` syntax

[hadley]

r-lib/roxygen2#1835

[JesseAlderliesten]

Using devtools::document() after upgrading roxygen2 from 7.3.3 to 8.0.0 removed RoxygenNote: 7.3.3 from the DESCRPTION and added Config/roxygen2/version: 8.0.0 instead.

However, usethis::use_roxygen_md() re-inserts RoxygenNote: 8.0.0 to the DESCRPTION. I suspect that is a bug but I am not sure and came across this issue when looking if someone filed this bug already, so asking here first without filing a new issue.

Re-inserting RoxygenNote: 8.0.0 happens because usethis::use_roxygen_md() calls usethis:::uses_roxygen() to check for the use of roxygen2, which looks for the just-removed RoxygenNote field and does not recognise the newly added Config/roxygen2/version field, nor the Roxygen field that is still in the DESCRPTION.

If it is a bug, adjusting usethis:::uses_roxygen() from proj_desc()$has_fields("RoxygenNote") to something like
any(usethis:::proj_desc()$has_fields(c("Roxygen", "RoxygenNote", "Config/roxygen2/version")), na.rm = TRUE) might solve it, but I'm not sure which of these fields should be checked, or if markdown = TRUE should be required in the Roxygen field (e.g., as implemented in usethis:::uses_roxygen_md()).

I'm using R 4.6.0 with roxygen2 8.0.0, usethis 3.2.1 and devtools 2.5.2.

[hadley]

Yes, this is a bug. But it feels like a minor bug since you only need to call use_roxygen_md() when porting a package that uses very old roxygen2.

[jonthegeek]

This also breaks use_import_from()

[JesseAlderliesten]

This also breaks use_import_from()

The new roxygen style indeed also breaks use_import_from() which is used a lot (running devtools::document() did not solve it):

Error in `check_uses_roxygen()`:
✖ Package develcoder does not use roxygen2.
ℹ `use_import_from()` can not work without it.
ℹ You might just need to run devtools::document() once, then try again.

So should I make a bugfix and do a pull request @hadley ?

[jennybc]

I plan on working on usethis soon, so yes it's a good time for PR(s?) that solve specific issues around the roxygen2 changes.

[JesseAlderliesten]

Searching the usethis code for RoxygenNote, I found that use_description_defaults() sets the 'old style' RoxygenNote field. Perhaps it is already on a to-do list, but that probably should be updated to use the 'new style' Config/roxygen2/version field conditional on the used version of roxygen2?