breaking-change-alert: failing with "missing input"

[jameslamb]

Description

For the last few weeks, breaking-change-alert has been failing in cuDF (and probably elsewhere) like this:

Run slackapi/slack-github-action@45a88b9581bfab2566dc881e2cd66d334e621e2c
Error: Missing input! Either a method or webhook is required to take action.
SlackError: Missing input! Either a method or webhook is required to take action.
    at Config.validate (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/src/config.js:210:1)
    at new Config (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/src/config.js:126:1)
    at send (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/src/send.js:12:1)
    at file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/src/index.js:9:1
    at __nccwpck_require__.a (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/webpack/runtime/async module:49:1)
    at Object.9722 (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/dist/index.js:47275:21)
    at __nccwpck_require__ (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/webpack/bootstrap:21:1)
    at file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/webpack/startup:4:1
    at ModuleJob.run (node:internal/modules/esm/module_job:437:25)
    at node:internal/modules/esm/loader:639:26

file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/src/config.js:210
        throw new SlackError(
^
SlackError: Missing input! Either a method or webhook is required to take action.
    at Config.validate (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/src/config.js:210:1)
    at new Config (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/src/config.js:126:1)
    at send (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/src/send.js:12:1)
    at file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/src/index.js:9:1
    at __nccwpck_require__.a (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/webpack/runtime/async module:49:1)
    at Object.9722 (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/dist/index.js:47275:21)
    at __nccwpck_require__ (file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/webpack/bootstrap:21:1)
    at file:///home/runner/work/_actions/slackapi/slack-github-action/45a88b9581bfab2566dc881e2cd66d334e621e2c/webpack/startup:4:1
    at ModuleJob.run (node:internal/modules/esm/module_job:437:25)
    at node:internal/modules/esm/loader:639:26

Reproducible Example

Recent example: https://github.com/rapidsai/cudf/actions/runs/26760834821

Notes

Looking through the blame (rapidsai/shared-workflows) I see the slackapi/slack-github-action had the following recent updates:

• 2 weeks ago: 3.0.1 -> 3.0.3 (chore(deps): update github-actions #542)
  2 months ago: 2.1.1 0 -> 3.0.1(chore(deps): update slackapi/slack-github-action action to v3 #513)

The last successful run was May 8th (https://github.com/rapidsai/cudf/actions/workflows/trigger-breaking-change-alert.yaml?query=is%3Asuccess)... which means maybe we were broken by a patch-version bump? 🙃

Approach

(task list added after finding the root cause in )

• shared-workflows: rename input, update docs (breaking-change-alert: fix webhook URL passing #561)
• test changes in 1 repo (https://github.com/rapidsai/literate-octo-potato/pull/928#issuecomment-4593987408)

Then, fix all callers (GitHub search)

• cucim (fix(ci): fix configuration for breaking change notification workflow cucim#1098)
• cudf (fix(ci): fix configuration for breaking change notification workflow cudf#22732)
• cugraph (fix(ci): fix configuration for breaking change notification workflow cugraph#5536)
• cugraph-gnn (fix(ci): fix configuration for breaking change notification workflow cugraph-gnn#473)
• cuml (fix(ci): fix configuration for breaking change notification workflow cuml#8199)
• cuopt (fix(ci): fix configuration for breaking change notification workflow NVIDIA/cuopt#1356)
• cuxfilter (fix(ci): fix configuration for breaking change notification workflow cuxfilter#790)
• cuvs (fix(ci): fix configuration for breaking change notification workflow cuvs#2151)
• dask-cuda (fix(ci): fix configuration for breaking change notification workflow dask-cuda#1654)
• devcontainers (fix(ci): fix configuration for breaking change notification workflow devcontainers#714)
• docker (fix(ci): fix configuration for breaking change notification workflow docker#886)
• integration (fix(ci): fix configuration for breaking change notification workflow integration#849)
• jupyterlab-nvdashboard (fix(ci): fix configuration for breaking change notification workflow jupyterlab-nvdashboard#260)
• kvikio (fix(ci): fix configuration for breaking change notification workflow kvikio#975)
• gha-tools (fix(ci): fix configuration for breaking change notification workflow gha-tools#260)
• raft (fix(ci): fix configuration for breaking change notification workflow raft#3048)
• rapids-cmake (fix(ci): fix configuration for breaking change notification workflow rapids-cmake#1036)
• rapids-dask-dependency (fix(ci): fix configuration for breaking change notification workflow rapids-dask-dependency#156)
• release-scripts (https://github.com/rapidsai/release-scripts/pull/90)
  • hopefully can be skipped if we merge https://github.com/rapidsai/release-scripts/pull/89
• rmm (fix(ci): fix configuration for breaking change notification workflow rmm#2435)
• ucxx (fix(ci): fix configuration for breaking change notification workflow ucxx#673)

[jameslamb]

It does appear that we're setting webhook: in the call to this action:

shared-workflows/.github/workflows/breaking-change-alert.yaml

Lines 173 to 174 in 583f3aa

	webhook: ${{ secrets.NV_SLACK_BREAKING_CHANGE_NOTIFIER_APP }}
	webhook-type: incoming-webhook

But interestingly, it's not showing up in the call to the action from that cuDF link above:

  with:
    payload: {
    "icon_emoji": ":information_source:",
    "username": "RAPIDS Breaking Change Notifier - Modified",
    "attachments": [
      {
        "author_name": "Modified PR by davidwendt",
        "author_link": "https://github.com/davidwendt",
        "author_icon": "https://avatars.githubusercontent.com/u/45795991?v=4",
        "color": "good",
        "fallback": "Breaking change PR Modified by davidwendt rapidsai/cudf#22601",
        "text": "<https://github.com/rapidsai/cudf/pull/22601|rapidsai/cudf#22601>",
        "fields": [
          {
            "title": "PR Title",
            "value": "Change behavior for regex class pattern [a-m-z]",
            "short": false
          },
          {
            "title": "PR Target",
            "value": "<https://github.com/rapidsai/cudf/tree/main|main>",
            "short": true
          },
          {
            "title": "PR Author",
            "value": "<https://github.com/davidwendt|davidwendt>",
            "short": true
          },
          {
            "title": "PR Description",
            "value": "## Description\r\nChanges the behavior of the regex pattern including chaining ranges to treat the non-primary range as literals.\r\nSo the pattern `[a-m-z]` would be the same as `[a-mz-]` or `[-za-m]`\r\nThis makes the behavior consistent with how python/pandas and java interpret this pattern.\r\n\r\nCloses: #22577 \r\n\r\n## Checklist\r\n- [x] I am familiar with the [Contributing Guidelines](https://github.com/rapidsai/cudf/blob/HEAD/CONTRIBUTING.md).\r\n- [x] New or existing tests cover these changes.\r\n- [x] The documentation is up to date with these changes.\r\n\n",
            "short": false
          }
        ],
        "footer": "<https://github.com/rapidsai/cudf|rapidsai/cudf>",
        "footer_icon": "https://avatars0.githubusercontent.com/u/43887749?s=32&v=4"
      }
    ]
  }
  
    payload-templated: true
    webhook-type: incoming-webhook
    errors: false
    retries: 5

(notice... no webhook: input!)

[jameslamb]

Think I see the issue. The actual org-level secret is called NV_SLACK_BREAKING_CHANGE_NOTIFIER_APP but in PRs like rapidsai/cudf#22343, secrets.NV_SLACK_BREAKING_CHANGE_ALERT was passed in.

That input doesn't exist so I guess GitHub silently treats it as null, which means it doesn't make it to the payload, which causes this error.

I'll fix this.