epic: architecture re-decomposition — physical splits, layer inversions, transport boundaries

[nextlevelshit]

Context

Synthesis of 22 audit-architecture pipeline runs (2026-04-10 → 2026-04-28). 16 reports, ~270 findings.

Progress (auto-tracked)

Merged PRs: 25

• PR fix(cmd): include 6 missing flags in runDetached argv (#1500) #1512 → closes fix(cmd): runDetached argv mirror silently drops 6 RunOptions fields #1500 (runDetached argv drift)
• PR docs(agents): sync internal/ pkg list to actual tree (#1507 partial) #1513 → partial docs+config: sync AGENTS.md File Structure; doc.go for 28 packages; centralize config readers #1507 (13.1 AGENTS.md sync)
• PR refactor: dedupe sanitizeBranch into pipeline pkg (#1503 partial 8.1) #1514 → partial refactor: dedupe sanitizeBranch, pipeline-YAML loaders, HTTP clients, credential redaction #1503 (8.1 sanitizeBranch dedupe)
• PR refactor(adapter,contract): mock to test pkg, no init panics (#1504 partial) #1515 → partial refactor: MockAdapter to _test.go; replace contract registry init() panics #1504 (9.1+9.2+9.4 mock+panics+nil-guard)
• PR refactor: invert defaults->pipeline import (#1497 partial 3.1) #1516 → partial refactor: invert 4 layering breaks (defaults→pipeline, event→state, webui→tui, onboarding→tui) #1497 (3.1 defaults→pipeline)
• PR refactor(tui): split content.go into per-panel files (#1505 partial) #1517 → closes refactor(tui): split content.go (2176 LOC) per panel; replace ContentProviders aggregator #1505 (content.go split)
• PR refactor(event): invert event->state dep via lifecycle consts (#1497 partial 3.2) #1518 → partial refactor: invert 4 layering breaks (defaults→pipeline, event→state, webui→tui, onboarding→tui) #1497 (3.2 event→state)
• PR refactor(health): extract internal/health; webui drops tui import (#1497 partial 3.3) #1519 → partial refactor: invert 4 layering breaks (defaults→pipeline, event→state, webui→tui, onboarding→tui) #1497 (3.3 webui→tui via internal/health)
• PR refactor(redact): consolidate redaction in internal/redact (#1503 partial 8.4) #1520 → partial refactor: dedupe sanitizeBranch, pipeline-YAML loaders, HTTP clients, credential redaction #1503 (8.4 credential redact)
• PR refactor: extract internal/pipelinecatalog from tui (#1497 partial 3.4) #1521 → partial refactor: invert 4 layering breaks (defaults→pipeline, event→state, webui→tui, onboarding→tui) #1497 (3.4 onboarding→tui via internal/pipelinecatalog)
• PR refactor(cmd): thin list.go; move logic to internal/listing (#1502 partial) #1522 → partial refactor(cmd): thin list.go (1630) + init.go (1575); move logic to internal/listing + internal/onboarding #1502 (list.go thin → internal/listing)
• PR docs: add package doc comments to internal/* (#1507 partial 13.2) #1523 → partial docs+config: sync AGENTS.md File Structure; doc.go for 28 packages; centralize config readers #1507 (13.2 doc.go for 19 packages)
• PR refactor(cmd): thin init.go; move logic to internal/onboarding (#1502 partial) #1524 → partial refactor(cmd): thin list.go (1630) + init.go (1575); move logic to internal/listing + internal/onboarding #1502 (init.go thin → internal/onboarding)
• PR refactor(manifest): centralize pipeline-YAML loaders (#1503 partial 8.2) #1525 → partial refactor: dedupe sanitizeBranch, pipeline-YAML loaders, HTTP clients, credential redaction #1503 (8.2 pipeline-YAML loader centralize)
• PR refactor(pipeline): split executor.go (6961 LOC) into per-concern files (#1495) #1526 → closes refactor(pipeline): physically split executor.go (6961 LOC) into per-concern files #1495 (executor.go physical split)
• PR refactor(webui,runner): extract internal/runner; thin handlers_control (#1498 partial) #1527 → partial refactor(webui): extract internal/runner + thin handlers; remove parallel orchestrator #1498 (internal/runner extract)
• PR refactor(pipeline): unify step strategy dispatch (#1506 partial) #1528 → closes refactor(pipeline): unify matrix/meta/composition under StrategyExecutor interface #1506 (StrategyExecutor unify matrix+composition)
• PR refactor(state): physically split store.go (3386 LOC) into per-domain files (#1496 partial) #1529 → partial refactor(state): retire StateStore umbrella; force narrow consumer interfaces #1496 (state/store.go physical split)
• PR refactor(cmd): relocate misplaced infra types out of run.go (#1499 partial) #1530 → partial refactor(cmd): split runRun god function; relocate misplaced infra in run.go #1499 (relocate 6 misplaced types)
• PR refactor(config): centralize env reads in internal/config (#1507 partial 13.3) #1531 → partial docs+config: sync AGENTS.md File Structure; doc.go for 28 packages; centralize config readers #1507 (13.3 partial: internal/config + 4 sites)
• PR refactor: extract internal/uitheme; onboarding no longer imports tui (#1497 residual) #1532 → closes refactor: invert 4 layering breaks (defaults→pipeline, event→state, webui→tui, onboarding→tui) #1497 (uitheme extract — final inversion)
• PR refactor: centralize HTTP client in internal/httpx (#1503 partial 8.3) #1533 → closes refactor: dedupe sanitizeBranch, pipeline-YAML loaders, HTTP clients, credential redaction #1503 (8.3 internal/httpx + 8.5 verify)
• PR refactor(cmd): move compose logic to internal/pipeline (#1502 partial) #1534 → partial refactor(cmd): thin list.go (1630) + init.go (1575); move logic to internal/listing + internal/onboarding #1502 (compose.go relocate)
• PR refactor(adapter,pipeline): Resolver iface + explicit ontology (#1504 close) #1535 → closes refactor: MockAdapter to _test.go; replace contract registry init() panics #1504 (Resolver iface + ontology default)
• PR refactor(cmd): split runRun god function into stages (#1499 close) #1536 → closes refactor(cmd): split runRun god function; relocate misplaced infra in run.go #1499 (runRun god split into stages)

Children fully closed: 9 of 13

• refactor(pipeline): physically split executor.go (6961 LOC) into per-concern files #1495 (executor split)
• refactor: invert 4 layering breaks (defaults→pipeline, event→state, webui→tui, onboarding→tui) #1497 (4 inversions + uitheme)
• refactor(cmd): split runRun god function; relocate misplaced infra in run.go #1499 (runRun split parts 1+2)
• fix(cmd): runDetached argv mirror silently drops 6 RunOptions fields #1500 (runDetached argv)
• refactor(cmd): thin list.go (1630) + init.go (1575); move logic to internal/listing + internal/onboarding #1502 (list.go + init.go + compose.go thinned; run.go now 375 LOC)
• refactor: dedupe sanitizeBranch, pipeline-YAML loaders, HTTP clients, credential redaction #1503 (sanitizeBranch + redact + yaml loader + httpx + formatDuration verify)
• refactor: MockAdapter to _test.go; replace contract registry init() panics #1504 (mock + panics + nil-guard + Resolver + ontology default)
• refactor(tui): split content.go (2176 LOC) per panel; replace ContentProviders aggregator #1505 (content.go split)
• refactor(pipeline): unify matrix/meta/composition under StrategyExecutor interface #1506 (matrix+composition strategy unified; meta deferred)

Still open: 4 of 13

• refactor(state): retire StateStore umbrella; force narrow consumer interfaces #1496 — Part 1 ✅ refactor(state): physically split store.go (3386 LOC) into per-domain files (#1496 partial) #1529 (file split); Part 2 pending: retire StateStore umbrella + force narrow consumer interfaces (XL invasive)
• refactor(webui): extract internal/runner + thin handlers; remove parallel orchestrator #1498 — Part 1 ✅ refactor(webui,runner): extract internal/runner; thin handlers_control (#1498 partial) #1527 (internal/runner extract); Part 2 pending: handlers_control ≤400 + webui→pipeline drop + projection extract + Server struct split (multi-PR)
• refactor(adapter): route llm_judge/skills_install/wave-reexec through internal/adapter #1501 — adapter routing partly via refactor(webui,runner): extract internal/runner; thin handlers_control (#1498 partial) #1527; remaining: webui handlers_skills sh -c → internal/skill+sandbox; tui git exec → internal/git (M)
• docs+config: sync AGENTS.md File Structure; doc.go for 28 packages; centralize config readers #1507 — 13.1 ✅ docs(agents): sync internal/ pkg list to actual tree (#1507 partial) #1513, 13.2 ✅ docs: add package doc comments to internal/* (#1507 partial 13.2) #1523, 13.3 partial ✅ refactor(config): centralize env reads in internal/config (#1507 partial 13.3) #1531; 13.4 Config sprawl + 13.5 internal/persona extract pending

Validation runs (post-#1495 + #1498 partial + #1499)

• ✅ wave-smoke-contracts (false-positive in test design — pre-existing, not regression; fix deferred)
• ✅ wave-smoke-gates
• ✅ wave-validate (full executor smoke pass)
• 🟡 wave-test-hardening still running

Audit sources

.agents/workspaces/audit-architecture-{20260420-125638-ca6b,20260421-233959-4dc5,20260422-002726-5f48,20260422-075324-49a5,20260422-181603-d598,20260422-223006-06af,20260422-225257-f666,20260426-203649-7d76,20260427-190911-64c2,20260427-222006-4393,20260427-222942-f3a7,20260427-233334-139a,20260428-000818-cab3,20260428-021145-05b4,20260428-180146-3ca6,20260428-182103-08a3}/report/.agents/output/architecture-report.md