Skip to content

Commit a23dd04

Browse files
robhoganchrfalch
authored andcommitted
[LOCAL] Backout #46896 - Attempt to fix #50274 (#52515)
1 parent b935c53 commit a23dd04

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1404,14 +1404,14 @@ private void detachRootViewFromInstance(ReactRoot reactRoot, ReactContext reactC
14041404
new RuntimeException(
14051405
"detachRootViewFromInstance called with ReactRootView with invalid id"));
14061406
}
1407-
1408-
clearReactRoot(reactRoot);
14091407
} else {
14101408
reactContext
14111409
.getCatalystInstance()
14121410
.getJSModule(AppRegistry.class)
14131411
.unmountApplicationComponentAtRootTag(reactRoot.getRootViewTag());
14141412
}
1413+
1414+
clearReactRoot(reactRoot);
14151415
}
14161416

14171417
@ThreadConfined(UI)

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/NativeViewHierarchyManager.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -679,9 +679,6 @@ public synchronized void removeRootView(int rootViewTag) {
679679
View rootView = mTagsToViews.get(rootViewTag);
680680
dropView(rootView);
681681
mRootTags.delete(rootViewTag);
682-
if (rootView != null) {
683-
rootView.setId(View.NO_ID);
684-
}
685682
}
686683

687684
/**

0 commit comments

Comments
 (0)