Skip to content

Commit bb27a16

Browse files
cipolleschimotiz88
authored andcommitted
Fix RCTPushNotification podspec to work with prebuilds (#52531)
Summary: This change tries to use the prebuilds we build in CI i other iOS jobs to speed-up the iOS CI bypass-github-export-checks ## Changelog: [Internal] - Pull Request resolved: #52531 Test Plan: Build rntester using prebuilds: ``` # after downloading the prebuilds from CI and unzipping them export HERMES_ENGINE_TARBALL_PATH=~/Downloads/hermes-ios-Debug.tar.gz export RCT_USE_LOCAL_RN_DEP=~/Downloads/reactnative-dependencies-debug.tar.gz export RCT_TESTONLY_RNCORE_TARBALL_PATH=~/Downloads/React.xcframework.tar.gz USE_FRAMEWORKS=dynamic bundle exec pod install open RNTesterPods.xcworkspace ``` And then build from Xcode. Reviewed By: rshest Differential Revision: D78158734 Pulled By: cipolleschi fbshipit-source-id: 43cbb66bd44fa621292b69de0dadde5ed20c4574
1 parent 6b8d1a0 commit bb27a16

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

packages/react-native/Libraries/PushNotificationIOS/React-RCTPushNotification.podspec

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ end
1818

1919
header_search_paths = [
2020
"\"${PODS_ROOT}/Headers/Public/ReactCodegen/react/renderer/components\"",
21+
"\"${PODS_ROOT}/Headers/Public/React-RCTFBReactNativeSpec/FBReactNativeSpec\"",
2122
]
2223

2324
Pod::Spec.new do |s|
@@ -45,7 +46,9 @@ Pod::Spec.new do |s|
4546
s.dependency "React-Core/RCTPushNotificationHeaders"
4647
s.dependency "React-jsi"
4748

48-
add_dependency(s, "React-RCTFBReactNativeSpec")
49+
add_dependency(s, "React-RCTFBReactNativeSpec", :additional_framework_paths => ['FBReactNativeSpec'])
4950
add_dependency(s, "ReactCommon", :subspec => "turbomodule/core", :additional_framework_paths => ["react/nativemodule/core"])
5051
add_dependency(s, "React-NativeModulesApple")
52+
53+
add_rncore_dependency(s)
5154
end

0 commit comments

Comments
 (0)