From 4009bc2079efdcaa9d92ec0461702986b2c12925 Mon Sep 17 00:00:00 2001 From: John Sabath Date: Wed, 19 Aug 2026 17:52:39 -0700 Subject: [PATCH] Bump OrtVersion to 1.29.0 to match onnxruntime_go v1.33.0 The go-dependencies group bump (#8) took onnxruntime_go from 1.31.0 to 1.33.0 without bumping OrtVersion alongside it, breaking the coupling the constant's own comment warns about. onnxruntime_go v1.33.0 vendors ORT_API_VERSION 29, so any binary built since #8 merged fails on inference against the 1.26.0 library `semantic init` downloads: The requested API version [29] is not available, only API versions [1, 26] are supported in this build. Nothing caught it because the affected tests skip when no model is installed, and shipped straight into the v0.2.0 release. ORT 1.29.0 is the release that defines ORT_API_VERSION 29; confirmed prebuilt archives exist for every platform this repo downloads for. Also note the coupling next to the dependabot group that broke it, so a reviewer of the next grouped bump knows to check for it. Signed-off-by: John Sabath --- .github/dependabot.yml | 5 +++++ pkg/embed/download.go | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index dcbe29d..fe8398b 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -10,6 +10,11 @@ updates: schedule: interval: weekly groups: + # onnxruntime_go in this group is version-coupled to the OrtVersion + # constant in pkg/embed/download.go (see the comment there): a bump here + # with no matching OrtVersion bump ships a binary that requests an ORT + # API version the downloaded library doesn't support, and nothing in CI + # catches it. Check the diff for onnxruntime_go before merging this group. go-dependencies: patterns: ["*"] open-pull-requests-limit: 3 diff --git a/pkg/embed/download.go b/pkg/embed/download.go index d0c95c1..a57e05b 100644 --- a/pkg/embed/download.go +++ b/pkg/embed/download.go @@ -15,14 +15,14 @@ import ( "time" ) -// OrtVersion is the ONNX Runtime release whose C API onnxruntime_go v1.31.0 +// OrtVersion is the ONNX Runtime release whose C API onnxruntime_go v1.33.0 // is built against. The two are coupled: the binding compiles against one // version of the headers and dlopens whatever this constant downloaded, so // bumping the Go module without bumping this constant produces a binary that // loads a library it was not compiled for. Nothing in CI catches that — the // tests skip inference when no model is installed — so the versions move // together, in one commit, or not at all. -const OrtVersion = "1.26.0" +const OrtVersion = "1.29.0" // OrtDownloadURL returns the GitHub release URL for the ORT shared library // archive for the current platform.