From e8e734f46f4c9cf8b1390bef6022e00170b518b2 Mon Sep 17 00:00:00 2001 From: "jesse.berger" Date: Mon, 4 May 2026 10:21:19 +0200 Subject: [PATCH] RT-17796 Fix wdrp/errp field errors --- src/Domain/TLDMetaData.php | 20 +++++++++---------- .../metadata/metadata_unknown_feature.php | 4 ++-- tests/Domain/data/metadata/metadata_valid.php | 3 +-- tests/Domain/data/tldinfo.php | 4 ++-- tests/Domain/data/tldinfo_com.json | 4 ++-- tests/Domain/data/tldinfo_nl.json | 4 ++-- 6 files changed, 19 insertions(+), 20 deletions(-) diff --git a/src/Domain/TLDMetaData.php b/src/Domain/TLDMetaData.php index 1be9e71..7aff11d 100644 --- a/src/Domain/TLDMetaData.php +++ b/src/Domain/TLDMetaData.php @@ -95,9 +95,9 @@ final class TLDMetaData implements DomainObjectInterface public ?LaunchPhaseCollection $launchPhases; - public bool $wdrpNotifications; + public ?bool $sendWdrpNotifications; - public bool $errpNotifications; + public ?bool $sendErrpNotifications; public ?int $transferLockDays; @@ -149,8 +149,8 @@ private function __construct( ?string $termsOfService, ?string $privacyPolicy, string $premiumSupport, - bool $wdrpNotifications, - bool $errpNotifications, + ?bool $sendWdrpNotifications, + ?bool $sendErrpNotifications, ?int $transferLockDays, string $renewalOnTransfer, ?string $registrationNotice, @@ -196,8 +196,8 @@ private function __construct( $this->termsOfService = $termsOfService; $this->privacyPolicy = $privacyPolicy; $this->premiumSupport = $premiumSupport; - $this->wdrpNotifications = $wdrpNotifications; - $this->errpNotifications = $errpNotifications; + $this->sendWdrpNotifications = $sendWdrpNotifications; + $this->sendErrpNotifications = $sendErrpNotifications; $this->transferLockDays = $transferLockDays; $this->renewalOnTransfer = $renewalOnTransfer; $this->registrationNotice = $registrationNotice; @@ -264,8 +264,8 @@ public static function fromArray(array $json): TLDMetaData $json['termsOfService'] ?? null, $json['privacyPolicy'] ?? null, $json['premiumSupport'], - $json['wdrpNotifications'], - $json['errpNotifications'], + $json['sendWdrpNotifications'], + $json['sendErrpNotifications'], $json['transferLockDays'] ?? null, $json['renewalOnTransfer'], $json['registrationNotice'] ?? null, @@ -308,8 +308,8 @@ public function toArray(): array 'whoisExposure' => $this->whoisExposure, 'gdprCategory' => $this->gdprCategory, 'premiumSupport' => $this->premiumSupport, - 'wdrpNotifications' => $this->wdrpNotifications, - 'errpNotifications' => $this->errpNotifications, + 'sendWdrpNotifications' => $this->sendWdrpNotifications, + 'sendErrpNotifications' => $this->sendErrpNotifications, 'transferLockDays' => $this->transferLockDays, 'domainSyntax' => $this->domainSyntax->toArray(), 'nameservers' => $this->nameservers->toArray(), diff --git a/tests/Domain/data/metadata/metadata_unknown_feature.php b/tests/Domain/data/metadata/metadata_unknown_feature.php index 88247a8..961edcf 100644 --- a/tests/Domain/data/metadata/metadata_unknown_feature.php +++ b/tests/Domain/data/metadata/metadata_unknown_feature.php @@ -23,8 +23,8 @@ 'whoisExposure' => '', 'gdprCategory' => '', 'premiumSupport' => 'REGULAR', - 'wdrpNotifications' => false, - 'errpNotifications' => false, + 'sendWdrpNotifications' => false, + 'sendErrpNotifications' => false, 'transferLockDays' => 0, 'domainSyntax' => ['minLength' => 1, 'maxLength' => 64, 'idnSupport' => false], // DomainSyntax 'nameservers' => ['min' => 0, 'max' => 13, 'required' => false], // Nameservers diff --git a/tests/Domain/data/metadata/metadata_valid.php b/tests/Domain/data/metadata/metadata_valid.php index aea6d44..ad407e0 100644 --- a/tests/Domain/data/metadata/metadata_valid.php +++ b/tests/Domain/data/metadata/metadata_valid.php @@ -23,8 +23,7 @@ 'whoisExposure' => 'FULL', 'gdprCategory' => 'EU_BASED', 'premiumSupport' => 'REGULAR', - 'wdrpNotifications' => false, - 'errpNotifications' => false, + 'sendWdrpNotifications' => false, 'transferLockDays' => 0, 'domainSyntax' => ['minLength' => 1, 'maxLength' => 64, 'idnSupport' => false], // DomainSyntax 'nameservers' => ['min' => 0, 'max' => 13, 'required' => false], // Nameservers diff --git a/tests/Domain/data/tldinfo.php b/tests/Domain/data/tldinfo.php index 4b4c0bc..5e0fa96 100644 --- a/tests/Domain/data/tldinfo.php +++ b/tests/Domain/data/tldinfo.php @@ -50,8 +50,8 @@ 'whoisExposure' => 'NONE', 'gdprCategory' => 'EU_BASED', 'premiumSupport' => 'REGULAR', - 'wdrpNotifications' => false, - 'errpNotifications' => false, + 'sendWdrpNotifications' => false, + 'sendErrpNotifications' => false, 'transferLockDays' => 0, 'domainSyntax' => include __DIR__ . '/domains/domain_syntax.php', 'nameservers' => include __DIR__ . '/nameservers.php', diff --git a/tests/Domain/data/tldinfo_com.json b/tests/Domain/data/tldinfo_com.json index eb15873..40608ce 100644 --- a/tests/Domain/data/tldinfo_com.json +++ b/tests/Domain/data/tldinfo_com.json @@ -464,8 +464,8 @@ "registrantChangeApprovalRequired": true, "allowDesignatedAgent": "BOTH", "validationCategory": "General", - "wdrpNotifications": false, - "errpNotifications": false, + "sendWdrpNotifications": false, + "sendErrpNotifications": false, "transferLockDays": 0, "renewalOnTransfer": "NO_CHANGE", "registrationNotice": "This is a registration notice!", diff --git a/tests/Domain/data/tldinfo_nl.json b/tests/Domain/data/tldinfo_nl.json index d62b458..5dfcc0d 100644 --- a/tests/Domain/data/tldinfo_nl.json +++ b/tests/Domain/data/tldinfo_nl.json @@ -123,8 +123,8 @@ "organizationRequired": false, "organizationAllowed": true }, - "wdrpNotifications": false, - "errpNotifications": true, + "sendWdrpNotifications": false, + "sendErrpNotifications": true, "transferLockDays": 0, "renewalOnTransfer": "RENEW_UNLESS_GRACE", "registrantChangeTransferLock": false,