From 3444d010ec38ce69c730af46cde06023ebcbaf58 Mon Sep 17 00:00:00 2001 From: Matthew Date: Tue, 13 Jan 2026 16:07:00 -0600 Subject: [PATCH] docs(bitcoinui): add per file sections --- commands/bitcoinui.md | 25 +++++++++++++++---------- site/bitcoinui.md | 25 +++++++++++++++---------- site/skills/bitcoinui/SKILL.md | 25 +++++++++++++++---------- skills/bitcoinui/SKILL.md | 25 +++++++++++++++---------- 4 files changed, 60 insertions(+), 40 deletions(-) diff --git a/commands/bitcoinui.md b/commands/bitcoinui.md index 2109ac2..670ccdc 100644 --- a/commands/bitcoinui.md +++ b/commands/bitcoinui.md @@ -31,26 +31,31 @@ If `$ARGUMENTS` is empty, ask: "Using the bitcoinui command for an iOS review. W ## Output Format Start directly with the `BITCOINUI` block; do not add any preamble text before it. +If a folder is reviewed, list each file as its own section (file path + findings + severities). +Omit any file section with 0 findings (do not list zero-findings files). Omit any severity section with 0 findings (including Low). ``` BITCOINUI -[file-or-folder] -Findings: X high, X medium, X low - -High -1) [UX L42] Missing warning for fee > amount - Fix: Add a warning state when fee >= 50% of amount. - Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ +SendFeeView.swift +Findings: 0 high, 2 medium, 0 low Medium -1) [A11Y L18] Icon-only button has no label +1) [UX L88] Fee picker lacks a high-fee warning + Fix: Add a warning when fee >= 50% of amount. + Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ +2) [A11Y L42] Icon-only close button has no label Fix: Add accessibilityLabel("Close") Ref: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility -Low -1) ... +ReceiveView.swift +Findings: 0 high, 1 medium, 0 low + +Medium +1) [QR L19] QR payload uses uri directly; bech32 should be uppercased for QR only + Fix: Uppercase only the bech32 address for QR encoding. + Ref: BIP173 https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki ``` ## Guidance diff --git a/site/bitcoinui.md b/site/bitcoinui.md index 2109ac2..670ccdc 100644 --- a/site/bitcoinui.md +++ b/site/bitcoinui.md @@ -31,26 +31,31 @@ If `$ARGUMENTS` is empty, ask: "Using the bitcoinui command for an iOS review. W ## Output Format Start directly with the `BITCOINUI` block; do not add any preamble text before it. +If a folder is reviewed, list each file as its own section (file path + findings + severities). +Omit any file section with 0 findings (do not list zero-findings files). Omit any severity section with 0 findings (including Low). ``` BITCOINUI -[file-or-folder] -Findings: X high, X medium, X low - -High -1) [UX L42] Missing warning for fee > amount - Fix: Add a warning state when fee >= 50% of amount. - Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ +SendFeeView.swift +Findings: 0 high, 2 medium, 0 low Medium -1) [A11Y L18] Icon-only button has no label +1) [UX L88] Fee picker lacks a high-fee warning + Fix: Add a warning when fee >= 50% of amount. + Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ +2) [A11Y L42] Icon-only close button has no label Fix: Add accessibilityLabel("Close") Ref: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility -Low -1) ... +ReceiveView.swift +Findings: 0 high, 1 medium, 0 low + +Medium +1) [QR L19] QR payload uses uri directly; bech32 should be uppercased for QR only + Fix: Uppercase only the bech32 address for QR encoding. + Ref: BIP173 https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki ``` ## Guidance diff --git a/site/skills/bitcoinui/SKILL.md b/site/skills/bitcoinui/SKILL.md index a2c0efc..aebf354 100644 --- a/site/skills/bitcoinui/SKILL.md +++ b/site/skills/bitcoinui/SKILL.md @@ -29,26 +29,31 @@ Review iOS SwiftUI code and screens for Bitcoin-specific UX correctness, iOS HIG ## Output Format Start directly with the `BITCOINUI` block; do not add any preamble text before it. +If a folder is reviewed, list each file as its own section (file path + findings + severities). +Omit any file section with 0 findings (do not list zero-findings files). Omit any severity section with 0 findings (including Low). ``` BITCOINUI -[file-or-folder] -Findings: X high, X medium, X low - -High -1) [UX L42] Missing warning for fee > amount - Fix: Add a warning state when fee >= 50% of amount. - Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ +SendFeeView.swift +Findings: 0 high, 2 medium, 0 low Medium -1) [A11Y L18] Icon-only button has no label +1) [UX L88] Fee picker lacks a high-fee warning + Fix: Add a warning when fee >= 50% of amount. + Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ +2) [A11Y L42] Icon-only close button has no label Fix: Add accessibilityLabel("Close") Ref: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility -Low -1) ... +ReceiveView.swift +Findings: 0 high, 1 medium, 0 low + +Medium +1) [QR L19] QR payload uses uri directly; bech32 should be uppercased for QR only + Fix: Uppercase only the bech32 address for QR encoding. + Ref: BIP173 https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki ``` ## References diff --git a/skills/bitcoinui/SKILL.md b/skills/bitcoinui/SKILL.md index a2c0efc..aebf354 100644 --- a/skills/bitcoinui/SKILL.md +++ b/skills/bitcoinui/SKILL.md @@ -29,26 +29,31 @@ Review iOS SwiftUI code and screens for Bitcoin-specific UX correctness, iOS HIG ## Output Format Start directly with the `BITCOINUI` block; do not add any preamble text before it. +If a folder is reviewed, list each file as its own section (file path + findings + severities). +Omit any file section with 0 findings (do not list zero-findings files). Omit any severity section with 0 findings (including Low). ``` BITCOINUI -[file-or-folder] -Findings: X high, X medium, X low - -High -1) [UX L42] Missing warning for fee > amount - Fix: Add a warning state when fee >= 50% of amount. - Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ +SendFeeView.swift +Findings: 0 high, 2 medium, 0 low Medium -1) [A11Y L18] Icon-only button has no label +1) [UX L88] Fee picker lacks a high-fee warning + Fix: Add a warning when fee >= 50% of amount. + Ref: Bitcoin Design Guide — Send fees https://bitcoin.design/guide/daily-spending-wallet/sending/send-fees/ +2) [A11Y L42] Icon-only close button has no label Fix: Add accessibilityLabel("Close") Ref: iOS HIG — Accessibility https://developer.apple.com/design/human-interface-guidelines/accessibility -Low -1) ... +ReceiveView.swift +Findings: 0 high, 1 medium, 0 low + +Medium +1) [QR L19] QR payload uses uri directly; bech32 should be uppercased for QR only + Fix: Uppercase only the bech32 address for QR encoding. + Ref: BIP173 https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki ``` ## References