UninitializedPropertyAccessException crash

[michal-luszczuk]

Hello we are using Android Refiner SDK in version 1.5.5.

Just recently we noticed increasing number of crashes (that were not there previously)

java.lang.RuntimeException: Unable to start activity ComponentInfo{app.package/io.refiner.ui.RefinerSurveyActivity}: i00.m0: lateinit property koinApp has not been initialized
    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3748)
    at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3885)
    at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:108)
    at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2379)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loopOnce(Looper.java:241)
    at android.os.Looper.loop(Looper.java:358)
    at android.app.ActivityThread.main(ActivityThread.java:8120)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:942)

kotlin.UninitializedPropertyAccessException: lateinit property koinApp has not been initialized
    at io.refiner.shared.LibKoinContext.getKoinApp(Koin.kt:0)
    at io.refiner.ui.RefinerSurveyFragment.viewModel_delegate$lambda$0(SourceFile:0)
    at io.refiner.ui.RefinerSurveyFragment.$r8$lambda$WEm-Gjh8FmdaIpyws5RQ-SI5Ij0(SourceFile:0)
    at io.refiner.ui.RefinerSurveyFragment$$ExternalSyntheticLambda1.invoke(RefinerSurveyFragment:0)
    at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:0)
    at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:83)
    at io.refiner.ui.RefinerSurveyFragment.getViewModel(SourceFile:0)
    at io.refiner.ui.RefinerSurveyFragment.onCreate(SourceFile:0)
    at io.refiner.ui.RefinerSurveyFragment.onCreate(SourceFile:11)
    at androidx.fragment.app.Fragment.performCreate(Fragment.java:0)
    at androidx.fragment.app.Fragment.performCreate(Fragment.java:3099)
    at androidx.fragment.app.FragmentStateManager.create(FragmentStateManager.java:524)
    at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:0)
    at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:282)
    at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:0)
    at androidx.fragment.app.FragmentStore.moveToExpectedState(FragmentStore.java:114)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:0)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1685)
    at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3319)
    at androidx.fragment.app.FragmentManager.dispatchCreate(FragmentManager.java:3226)
    at androidx.fragment.app.FragmentController.dispatchCreate(FragmentController.java:0)
    at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:0)
    at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:219)
    at io.refiner.ui.RefinerSurveyActivity.onCreate(SourceFile:2)
    at android.app.Activity.performCreate(Activity.java:8357)
    at android.app.Activity.performCreate(Activity.java:8336)
    at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1385)
    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3729)
    at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3885)
    at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:108)
    at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2379)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loopOnce(Looper.java:241)
    at android.os.Looper.loop(Looper.java:358)
    at android.app.ActivityThread.main(ActivityThread.java:8120)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:942)

1. Are you aware of this issue?
2. What can we do to fix it?

[tekinalper]

Hi @michal-luszczuk,
Did the crashes happen after upgrading the version, or were they occurring while using version 1.5.5?

[michal-luszczuk]

I don't know. Because we use 1.5.5 now, so no data how it behaves on 1.5.6

Are there any changes on 1.5.6 that potentially can fix code related to the crash?

[tekinalper]

@michal-luszczuk

1. I actually meant version 1.5.5, not 1.5.6. Did the crashes start immediately after upgrading to 1.5.5, or did they begin occurring some time after the upgrade to 1.5.5?
2. Have you made any changes to the Refiner SDK initialization process? For example, are you still initializing Refiner directly in your application's onCreate() method?

In the meantime, I’ll continue investigating what might be causing this.

[michal-luszczuk]

Did the crashes start immediately after upgrading to 1.5.5, or did they begin occurring some time after the upgrade to 1.5.5?

After some time. But i don't know what is the trigger, as I am not able to reproduce this issue.

Have you made any changes to the Refiner SDK initialization process? For example, are you still initializing Refiner directly in your application's onCreate() method?

No changes recently. From the beginning our implementation was:
We initialize the SDK on demand. So as we are on screen on which we may open the Refiner form, before starting the flow we are calling Refiner.initialize and we guard, that it will happen only once per whole app lifecycle

[tekinalper]

We initialize the SDK on demand. So as we are on screen on which we may open the Refiner form, before starting the flow we are calling Refiner.initialize and we guard, that it will happen only once per whole app lifecycle

To clarify: Do you call initialize in your Application class or in a screen(in a fragment or Activity) before showing the survey?

This might be the issue, we expect calling initialize in the Application class of the app.

[michal-luszczuk]

To clarify: Do you call initialize in your Application class or in a screen(in a fragment or Activity) before showing the survey?

No. We call it on demand. So on the specific screen as we will evaluate that this is a right time to show the survey, at first we are calling Refiner.initialize and after that we are calling rest of the methods Refiner.identifyUser, Refiner.addToResponse and finally Refiner.showForm

There are a lot of 3rd party SDKs that needs to be initialized, so we try to load them lazily on demand (only after we know that the SDK is needed/ the form will be presented). By doing this we try to speed up the app launch time.

This might be the issue, we expect calling initialize in the Application class of the app.

Does it mean that Refiner.initialize is doing some asynchronous work that may not finish by the time of calling Refiner.showForm ?
What is the main motivation/reason to expect this Refiner.initialize to be called on Application.onCreate ?

[tekinalper]

That is great info @michal-luszczuk, thanks for letting me know your use-case and the reason behind it.

It was actually to guarantee the initialization before calling any method. I've added the fix for the next version which we'll release very soon.

[tekinalper]

Version 1.5.7 released

[JustinGeorgeJoseph]

Hi @tekinalper,

We are still receiving crash reports related to this issue. We’re currently using version 1.5.9, and previously observed the same crash in 1.5.8 as well.

Since we upgraded directly from 1.5.6 to 1.5.8, we’re not sure whether the fix in 1.5.7 was applied. Could you please take another look at this issue?

Thank you.

[JustinGeorgeJoseph]

Hi @tekinalper,

We are still encountering an UninitializedPropertyAccessException from the Refiner SDK while using version 1.5.10.
Could you please take a look at this issue?

Thank you very much.

io.refiner.shared.LibKoinContext in getKoinApp
io.refiner.ui.RefinerSurveyFragment in viewModel_delegate$lambda$0
io.refiner.ui.RefinerSurveyFragment in $r8$lambda$WEm-Gjh8FmdaIpyws5RQ-SI5Ij0
io.refiner.ui.RefinerSurveyFragment$$ExternalSyntheticLambda1 in invoke
kotlin.SynchronizedLazyImpl in getValue
kotlin.SynchronizedLazyImpl in getValue at line 86
io.refiner.ui.RefinerSurveyFragment in getViewModel
io.refiner.ui.RefinerSurveyFragment in onCreate
io.refiner.ui.RefinerSurveyFragment in onCreate at line 11
androidx.fragment.app.Fragment in performCreate
androidx.fragment.app.Fragment in performCreate at line 3099
androidx.fragment.app.FragmentStateManager in create at line 524
androidx.fragment.app.FragmentStateManager in moveToExpectedState
androidx.fragment.app.FragmentStateManager in moveToExpectedState at line 282
androidx.fragment.app.FragmentStore in moveToExpectedState
androidx.fragment.app.FragmentStore in moveToExpectedState at line 114
androidx.fragment.app.FragmentManager in moveToState
androidx.fragment.app.FragmentManager in moveToState at line 1685
androidx.fragment.app.FragmentManager in dispatchStateChange at line 3319
androidx.fragment.app.FragmentManager in dispatchCreate at line 3226
androidx.fragment.app.FragmentController in dispatchCreate
androidx.fragment.app.FragmentActivity in onCreate
androidx.fragment.app.FragmentActivity in onCreate at line 219
io.refiner.ui.RefinerSurveyActivity in onCreate at line 2
android.app.Activity in performCreate at line 9519
android.app.Activity in performCreate at line 9488
android.app.Instrumentation in callActivityOnCreate at line 1524
android.app.ActivityThread in performLaunchActivity at line 4692
android.app.ActivityThread in handleLaunchActivity at line 4941
android.app.servertransaction.LaunchActivityItem in execute at line 222
android.app.servertransaction.TransactionExecutor in executeNonLifecycleItem at line 133
android.app.servertransaction.TransactionExecutor in executeTransactionItems at line 103
android.app.servertransaction.TransactionExecutor in execute at line 80
android.app.ActivityThread$H in handleMessage at line 3150
android.os.Handler in dispatchMessage at line 110
android.os.Looper in loopOnce at line 273
android.os.Looper in loop at line 363
android.app.ActivityThread in main at line 10060
java.lang.reflect.Method in invoke
com.android.internal.os.RuntimeInit$MethodAndArgsCaller in run at line 632
com.android.internal.os.ZygoteInit in main at line 975

RuntimeException
Unable to start activity ComponentInfo{com.app/io.refiner.ui.RefinerSurveyActivity}: kotlin.UninitializedPropertyAccessException: lateinit property koinApp has not been initialized
android.app.ActivityThread in performLaunchActivity at line 4710
android.app.ActivityThread in handleLaunchActivity at line 4941
android.app.servertransaction.LaunchActivityItem in execute at line 222
android.app.servertransaction.TransactionExecutor in executeNonLifecycleItem at line 133
android.app.servertransaction.TransactionExecutor in executeTransactionItems at line 103
android.app.servertransaction.TransactionExecutor in execute at line 80
android.app.ActivityThread$H in handleMessage at line 3150
android.os.Handler in dispatchMessage at line 110
android.os.Looper in loopOnce at line 273
android.os.Looper in loop at line 363
android.app.ActivityThread in main at line 10060
java.lang.reflect.Method in invoke
com.android.internal.os.RuntimeInit$MethodAndArgsCaller in run at line 632
com.android.internal.os.ZygoteInit in main at line 975

[tekinalper]

Hi @JustinGeorgeJoseph, thanks for letting me know about trying the new version. I'll check it again.

[JustinGeorgeJoseph]

Hi @tekinalper,
Do you have any updates on this issue? What do you think about reopening it to get more visibility?

[tekinalper]

@JustinGeorgeJoseph I'll release a new version soon, sorry for the delay here. Reopened the issue.