Add a check to be sure we do not have the same tag in our model#8
Open
christophe-dufour wants to merge 1 commit intorelops:masterfrom
Open
Add a check to be sure we do not have the same tag in our model#8christophe-dufour wants to merge 1 commit intorelops:masterfrom
christophe-dufour wants to merge 1 commit intorelops:masterfrom
Conversation
Member
|
Thanks for contributing this - the basic idea is sound - the reason why the build is not passing appears to be an issue with upgrading to the latest version of gocql (specifically dealing with the dec/inf upgrade that took place there). #9 was attempt to quickly solve this, but we've run into a test failure that is not immediately apparent about how to fix it. |
|
what is the progress with this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent a lot of time trying to debug my code.
I just made a typo, and I had to cql tags with the same name.
This PR add a check to show an error when it happens.