Skip to content

"refine_steps" argument name and docs are misleading #54

@iuliaturc

Description

@iuliaturc

When setting refiner=base_image_refiner, the refine_steps argument promises to control how many denoising steps will be performed with the refiner:

Screenshot 2024-05-09 at 11 39 35 AM

However, in practice, this is only true if you additional set prompt_strength=1.0. The reason is that:

  • cog-sdxl sets num_inference_steps=refiner_steps here, and
  • diffusers computes the init_step for refinement based both on num_inference_steps and strength here.

This results in surprising behavior, where you set refiner_steps=N only to see that it ran for fewer steps. I think you could either:

  • Update your documentation to reflect this reality, or
  • Automatically set strength=1 here

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions