Skip to content

DefaultSslContextFactory doesn't handle enabledCipherSuites/enabledProtocols parameters properly #853

@jkeljo

Description

@jkeljo

If you specify "enabledCipherSuites" but not "enabledProtocols", the "enabledCipherSuites" are ignored. The root of the issue is what looks like a copy/paste error in DefaultSslContextFactory.init(), which clears the enabled cipher suites if no enabled protocols are provided (the parallel code for disabledCipherSuites/disabledProtocols does not do this):

        if (enabledProtocols.size() > 0) {
            enabledProtocolsArray = new String[enabledProtocols.size()];
            enabledProtocols.toArray(enabledProtocolsArray);
            setEnabledProtocols(enabledProtocolsArray);
        } else {
            setEnabledCipherSuites(null);
        }

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions