Test with GitHub Enterprise

[mnuttall]

Most of our testing so far has been on public GitHub. Re-test against GitHub Enterprise.

[a-roberts]

@akihikokuroda I know you mentioned this yesterday on an IBM scrum, are you planning to pick this up? We have experience here before from the Tekton Webhooks Extension work and previous projects at IBM - using the Git client without providing a URL results in github.com and we need a way to look at the URL and use that as the Git provider surely (and IIRC that was a simple parameter passed in to the client).

[bigkevmcd]

You'll want to add a new command-line option for the git endpoint, and thread it through to here (via the factory in the service manager).

https://github.com/rhd-gitops-example/services/blob/master/pkg/git/client.go#L13

The factory code is here, https://github.com/jenkins-x/go-scm/blob/master/scm/factory/factory.go#L28 and as you'll spot, you can pass a serverURL (which can default to "").

[akihikokuroda]

Ok. Do you have any suggestions for the option name?