Order of methods matter in Email::Stuffer 0.012

[szabgab]

I just bumped into this issue using Email::Stuffer 0.012

If I create the email this way:

Email::Stuffer->text_body($text)->subject($subject)->from($from)->to($to)->send;

The generated e-mail in my Mailfolder looks like this:

---

Date: Thu, 7 May 2015 19:47:04 +0300
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: quoted-printable
Subject: Experiment
X-Email-Sender-From: gabor@perlmaven.com
X-Email-Sender-To: gabor@szabgab.com
Lines: 1

Text

and the message is rejected by Google due to lack of RFC conformity.

If I change the order of the calls to

Email::Stuffer->text_body($text)->from($from)->to($to)->subject($subject)->send;

---

Date: Thu, 7 May 2015 19:51:12 +0300
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8";
format="flowed"Content-Transfer-Encoding: quoted-printable
From: G Sz gabor@perlmaven.com
To: gabor@szabgab.com
Subject: Experiment
X-Email-Sender-From: gabor@perlmaven.com
X-Email-Sender-To: gabor@szabgab.com
Lines: 2

Experimental message

---

and the message is delivered properly.

I don't think I saw in the docs that the order matters. So this seems to be
either a bug in the code or a need to updated the docs.

(also reported as https://rt.cpan.org/Ticket/Display.html?id=104299 sorry for that.)

[krismatthews]

Hi @szabgab, I've taken a quick look at this and cannot reproduce any problem with Gmail - the email I've sent goes through regardless of the order of the headers. I do see the headers being in a different order matching the order of the calls to Email::Stuffer, but I do not think the order matters - the RFC says "It is important to note that the header fields are not guaranteed to be in a particular order".

That does not of course preclude some odd bug being fixed in Email::MIME (or on googles servers) between the filing of this ticket and when I tried to reproduce.

Here's the .t file I used (with passwords/etc redacted):

#!/usr/bin/env perl
use strict;
use warnings;

use Test::More;
use Email::Stuffer;

use Email::Sender::Transport::SMTP;

my $transport = Email::Sender::Transport::SMTP->new(
    host          => 'smtp.fastmail.com',
    port          => 465,
    ssl           => 1,
    sasl_username => 'username',
    sasl_password => 'password',
    debug         => 0,
);

my $to = 'someone at gmail';

Email::Stuffer
    ->text_body ( 'this is only a test'     )
    ->from      ( $transport->sasl_username )
    ->to        ( $to                       )
    ->subject   ( 'this is only a subject'  )
    ->transport ( $transport                )
    ->send;

print $@, "\n" if $@;

done_testing();