Issue with Data Type Handling: Decimal/Float Displayed as Date

[maverik23]

Package Version

v1.0.7

Laravel Version

v10.48.25

PHP Version

8.2.26

Problem description

When updating a value through the form, the plugin displays it as a date. However, in my model, the field is configured as a float, and in the database, it is set as decimal(15,2). While Spatie correctly stores the values, the plugin retrieves and displays them as a date instead of a float.

Let me know if additional details are needed to help resolve this issue. Thank you!

Expected behavior

The field should be displayed as a float or decimal value in the same format as it is stored in the database (decimal(15,2)), consistent with the configuration in the model (float). There should be no conversion or misinterpretation of the value as a date.

Steps to reproduce

1. Configure a field in the model as float.
2. Set the corresponding database column as decimal(15,2).
3. Update the value of the field through the form.
4. Observe how the field is displayed in the plugin; it appears as a date instead of a float/decimal.

Reproduction repository (issue will be closed if this is not valid)

none

Relevant log output

No response

[AxelvdS]

The issue seems to be in the actionContent.php concern with the function formatDateValues. Adding the following resolves the issue:

        if (date_parse($value)['error_count'] > 0 || !date_parse($value)['year']) {
            return $value;
        }                

The resulting function becomes then:

    private static function formatDateValues(array|string|null $value): array|string|null
    {
        if (is_null($value)) {
            return $value;
        }

        if (is_array($value)) {
            foreach ($value as &$item) {
                $item = self::formatDateValues($item);
            }

            return $value;
        }
        if (date_parse($value)['error_count'] > 0 || !date_parse($value)['year']) {
            return $value;
        }                
        try {
            return Carbon::parse($value)
                ->format(config('filament-activitylog.datetime_format', 'd/m/Y H:i:s'));
        } catch (InvalidFormatException $e) {
            return $value;
        }
    }

[AxelvdS]

And if you want to have dates without time shown without the 00:00:00, you can add 'date_format' => 'd/m/Y ', to the filament-activitylog file and add the following for handling dates without time:

        if (!date_parse($value)['hour']) {
            try {
                return Carbon::parse($value)
                    ->format(config('filament-activitylog.date_format', 'd/m/Y'));
            } catch (InvalidFormatException $e) {
                return $value;
            }
        }

The function becomes then:

    private static function formatDateValues(array|string|null $value): array|string|null
    {
        if (is_null($value)) {
            return $value;
        }

        if (is_array($value)) {
            foreach ($value as &$item) {
                $item = self::formatDateValues($item);
            }

            return $value;
        }
        if (date_parse($value)['error_count'] > 0 || !date_parse($value)['year']) {
            return $value;
        }                
        if (!date_parse($value)['hour']) {
            try {
                return Carbon::parse($value)
                    ->format(config('filament-activitylog.date_format', 'd/m/Y'));
            } catch (InvalidFormatException $e) {
                return $value;
            }
        }
        try {
            return Carbon::parse($value)
                ->format(config('filament-activitylog.datetime_format', 'd/m/Y H:i:s'));
        } catch (InvalidFormatException $e) {
            return $value;
        }
    }

[maverik23]

ok, this works.
Do you plan to add this in the next update or should I implement it manually in my code?

[AxelvdS]

I am just a user like you :)
We just need to wait for Romulo to pick this up

[SerjoA]

need to add lines:

       if ($value === false) {
         return 'false';
      }

      if ($value === true) {
         return 'true';
      }

    if (is_numeric($value)) {
       return $value;
    }

in file: ActionContent.php
in function : \Rmsramos\Activitylog\Actions\Concerns\ActionContent::formatDateValues

right after:

   if (is_array($value)) {
         foreach ($value as &$item) {
            $item = self::formatDateValues($item);
         }

         return $value;
      }

this will fix all issues, including display of boolean values which is missing from other forks or solutions

[sshocked]

For time waiting Romulo before pickup you can create custom class and overwrite two methods, then change ActivityLogTimelineTableAction with ActivityLogTimelineTableCustomAction:

<?php

namespace App\Filament\Actions;

use Illuminate\Support\Carbon;
use Rmsramos\Activitylog\Actions\ActivityLogTimelineTableAction;
use Carbon\Exceptions\InvalidFormatException;

use Rmsramos\Activitylog\Actions\Concerns\ActionContent;
class ActivityLogTimelineTableCustomAction extends ActivityLogTimelineTableAction
{
    private static function formatDateValues(array|string|null $value): array|string|null
    {
        if (is_null($value)) {
            return $value;
        }

        if (is_array($value)) {
            foreach ($value as &$item) {
                $item = self::formatDateValues($item);
            }

            return $value;
        }

        if ($value === false) {
            return 'false';
        }

        if ($value === true) {
            return 'true';
        }

        if (is_numeric($value)) {
            return $value;
        }

        try {
            return Carbon::parse($value)
                ->format(config('filament-activitylog.datetime_format', 'd/m/Y H:i:s'));
        } catch (InvalidFormatException $e) {
            return $value;
        }
    }

    protected function formatActivityData($activity): array
    {
        return [
            'log_name'    => $activity->log_name,
            'description' => $activity->description,
            'subject'     => $activity->subject,
            'event'       => $activity->event,
            'causer'      => $activity->causer,
            'properties'  => $this->formatDateValues(json_decode($activity->properties, true)),
            'batch_uuid'  => $activity->batch_uuid,
            'update'      => $activity->updated_at,
        ];
    }
}

[RyanPaiva56]

I can reproduce this on the latest version.