Issue: SQL Error When Using hasManyThrough or belongsToMany in Activity Timeline Sidebar

[jangidgirish]

Package Version

v1.0.10

Laravel Version

v12.x.x

PHP Version

PHP 8.3.20

Problem description

I am attempting to add an activity timeline sidebar to a resource using the following code:

ActivityLogTimelineTableAction::make('Activities')
    ->withRelations(['hasManyThroughRelation', 'belongsToManyRelation']);

However, when using hasManyThrough or belongsToMany relationships, the timeline throws a SQL error:

SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'id' in SELECT is ambiguous

It seems the query generated does not alias the id column properly, returning ambiguity when joining tables. This issue only occurs when certain relationships like hasManyThrough or belongsToMany are used.

Expected behavior

Expected Behavior:
The timeline should handle complex relationships without generating ambiguous column errors.

Steps to reproduce

Steps to Reproduce

1. Create a Filament resource that includes an ActivityLogTimelineTableAction sidebar.

2. In the table() method or corresponding section of your resource, define the timeline action like this:

   ActivityLogTimelineTableAction::make('Activities')
       ->withRelations(['hasManyThroughRelation', 'belongsToManyRelation']);

3. Ensure that the specified relations (hasManyThroughRelation, belongsToManyRelation) are valid and defined in your model.

4. Navigate to the resource page in the Filament admin panel.

5. When the page loads, observe the error thrown:

   SQLSTATE[23000]: Integrity constraint violation: 1052 Column 'id' in SELECT is ambiguous
   

This issue occurs due to unqualified id columns in the generated SQL query when using complex relationships like hasManyThrough or belongsToMany.

Reproduction repository (issue will be closed if this is not valid)

no

Relevant log output

[jangidgirish]

Any update on this issue?

[jangidgirish]

activitylog/src/Actions/Concerns/ActionContent.php

Line 70 in 56719bf

->whereIn('subject_id', $record->{$relation}()->pluck('id'));

to

->whereIn('subject_id', $record->{$relation}()->pluck((new $model)->getTable().'.id'));

i guess, it can resolve DB error bug

[rmsramos]

@jangidgirish create a repository and send the url, with the error reproduction so I can check

[msrivela]

@rmsramos I ran across the same problem, so I created a repository for it:
https://github.com/msrivela/filament-issue-activity-log

It's standard filament issue, just run composer install and php artisan serve.

I created a resource called ItemResource, where I request activitylog for relations "subItem" and "subSubItem", "subSubItem" being a HasManyThrough relationship.

The solution proposed by @jangidgirish seems to be a bit outdated. Given the current codebase, it would be changing

activitylog/src/Actions/Concerns/ActionContent.php

Line 92 in 09e6683

$relatedIds = $relationInstance->pluck('id')->toArray();

to

 $relatedIds = $relationInstance->pluck((new $relatedModel)->getTable().'.id')->toArray();

Currently the exception described by @jangidgirish is caught and ignored, so the only symptom is the log not being displayed.

[paulohenriquesg]

Inspired by the solution provided by @msrivela, I created this PR #114.

As I don't have a HasManyThrough relationship, I could not test that use case, but I do have a BelongsToMany and it works 😄

[jangidgirish]

@msrivela i was figure out quickly, but i also like your option, can you fix it and raise pull request.