Skip to content

Fix unused return value of apply_move #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adbjesus merged 1 commit into from
Jul 1, 2025
Merged

Fix unused return value of apply_move #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/roar_net_api/algorithms/best_improvement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def best_improvement(problem: _Problem[_TSolution], solution: _TSolution) -> _TS

log.info(f"Best increment: {best_incr}")

best_move.apply_move(solution)
solution = best_move.apply_move(solution)

move_iter = iter(_valid_moves_and_increments(neigh, solution))
move_and_incr = next(move_iter, None)
Expand Down
2 changes: 1 addition & 1 deletion src/roar_net_api/algorithms/first_improvement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def first_improvement(problem: _Problem[_TSolution], solution: _TSolution) -> _T

if increment < 0:
log.info(f"Found increment: {increment}")
move.apply_move(solution)
solution = move.apply_move(solution)
move_iter = iter(_valid_moves_and_increments(neigh, solution))

move_and_incr = next(move_iter, None)
Expand Down
2 changes: 1 addition & 1 deletion src/roar_net_api/algorithms/grasp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def grasp(
thresh = cmin + alpha * (cmax - cmin)
rcl = [m for m, decr in cl if decr <= thresh]
m = random.choice(rcl)
m.apply_move(s)
s = m.apply_move(s)
obj = s.objective_value()
if obj is not None and (bobj is None or obj < bobj):
b = s.copy_solution()
Expand Down
4 changes: 2 additions & 2 deletions src/roar_net_api/algorithms/greedy_construction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def greedy_construction(problem: _Problem[_TSolution], solution: Optional[_TSolu
if incr == 0:
break

best_move.apply_move(solution)
solution = best_move.apply_move(solution)

move_iter = iter(_valid_moves_and_increments(neigh, solution))
move_and_incr = next(move_iter, None)
Expand Down Expand Up @@ -86,7 +86,7 @@ def greedy_construction_with_random_tie_breaking(
best_moves.append(move)

log.info(f"Best increment: {best_incr}")
random.choice(best_moves).apply_move(solution)
solution = random.choice(best_moves).apply_move(solution)

move_iter = iter(_valid_moves_and_increments(neigh, solution))
move_and_incr = next(move_iter, None)
Expand Down
2 changes: 1 addition & 1 deletion src/roar_net_api/algorithms/sa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def sa(
assert incr is not None

if acceptance(incr, t) >= random.random():
move.apply_move(solution)
solution = move.apply_move(solution)
obj = solution.objective_value()
assert obj is not None

Expand Down
Loading