fix(ci): resolve clippy lint violations in credentials/compute modules

- Backtick type names in doc comments (doc_markdown)
- Change pub(crate) to pub for external module and connect fn (redundant_pub_crate)
- Inline format args in credentials error messages (uninlined_format_args)
- Flip if-not-else to positive condition (if_not_else)

Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: Paolo Dettori <dettori@us.ibm.com>

Author: pdettori

crates/openshell-server/src/cli.rs

@@ -278,14 +278,14 @@ struct Args {
     oidc_scopes_claim: String,
 
     /// Unix domain socket path to an external compute driver.
-    /// Use with `--driver external` to delegate ComputeDriver RPCs to a
+    /// Use with `--driver external` to delegate `ComputeDriver` RPCs to a
     /// pre-existing out-of-process driver (e.g. a sidecar container).
     #[arg(long, env = "OPENSHELL_COMPUTE_DRIVER_SOCKET")]
     compute_driver_socket: Option<PathBuf>,
 
     /// Unix domain socket path to a credentials driver.
     /// When set, the gateway delegates credential resolution to this
-    /// out-of-process driver via the CredentialsDriver gRPC contract.
+    /// out-of-process driver via the `CredentialsDriver` gRPC contract.
     #[arg(long, env = "OPENSHELL_CREDENTIALS_DRIVER_SOCKET")]
     credentials_driver_socket: Option<PathBuf>,
 }

crates/openshell-server/src/compute/external.rs

@@ -24,7 +24,7 @@ use tower::service_fn;
 ///
 /// Retries for up to 10 seconds to allow the sidecar time to start.
 #[cfg(unix)]
-pub(crate) async fn connect(socket_path: &std::path::Path) -> Result<Channel> {
+pub async fn connect(socket_path: &std::path::Path) -> Result<Channel> {
     let mut last_error: Option<String> = None;
     for _ in 0..100 {
         match connect_once(socket_path).await {

crates/openshell-server/src/compute/mod.rs

@@ -3,7 +3,7 @@
 
 //! Gateway-owned compute orchestration over a pluggable compute backend.
 
-pub(crate) mod external;
+pub mod external;
 pub mod vm;
 
 pub use openshell_driver_docker::DockerComputeConfig;

crates/openshell-server/src/credentials.rs

@@ -52,8 +52,7 @@ impl CredentialsDriverHandle {
             .await
             .map_err(|s| {
                 Error::execution(format!(
-                    "credentials driver ResolveCredential failed for '{}': {}",
-                    name, s
+                    "credentials driver ResolveCredential failed for '{name}': {s}"
                 ))
             })?;
         Ok(response.into_inner())
@@ -66,7 +65,7 @@ impl CredentialsDriverHandle {
             .list_credentials(tonic::Request::new(ListCredentialsRequest {}))
             .await
             .map_err(|s| {
-                Error::execution(format!("credentials driver ListCredentials failed: {}", s))
+                Error::execution(format!("credentials driver ListCredentials failed: {s}"))
             })?;
         Ok(response.into_inner())
     }

crates/openshell-server/src/lib.rs

@@ -207,12 +207,12 @@ pub async fn run_server(
     )
     .await?;
 
-    let credentials_driver = if !config.credentials_driver_socket.is_empty() {
+    let credentials_driver = if config.credentials_driver_socket.is_empty() {
+        None
+    } else {
         let socket_path = std::path::Path::new(&config.credentials_driver_socket);
         let handle = credentials::CredentialsDriverHandle::connect(socket_path).await?;
         Some(Arc::new(handle))
-    } else {
-        None
     };
 
     let state = Arc::new(ServerState::new(