fix: resolve clippy and dead-code lint warnings

- Replace match in display_name with map_or (option_if_let_else)
- Collapse nested if-let in create_provider (collapsible_if)
- Remove needless borrow in detach handler (needless_borrow)
- Allow dead_code on owner_prefix and scoped_name_for_principal
  (used in tests; needed for admin addressability TODO)

Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: Paolo Dettori <dettori@us.ibm.com>

Author: pdettori

crates/openshell-server/src/auth/ownership.rs

@@ -188,19 +188,20 @@ pub fn scoped_name(owner: &str, name: &str) -> String {
 /// If the key contains a `/`, the part after the first `/` is the display name.
 /// If no `/`, the key *is* the display name (shared/legacy provider).
 pub fn display_name(db_key: &str) -> &str {
-    match db_key.find(SCOPE_SEPARATOR) {
-        Some(pos) => &db_key[pos + 1..],
-        None => db_key,
-    }
+    db_key
+        .find(SCOPE_SEPARATOR)
+        .map_or(db_key, |pos| &db_key[pos + 1..])
 }
 
 /// Extract the owner prefix from a scoped DB key, if present.
+#[allow(dead_code)] // Used in tests; needed for admin addressability (TODO).
 pub fn owner_prefix(db_key: &str) -> Option<&str> {
     db_key.find(SCOPE_SEPARATOR).map(|pos| &db_key[..pos])
 }
 
 /// Build the scoped DB key for the given principal, or return the raw name for
 /// anonymous/admin callers.
+#[allow(dead_code)] // Used in tests; needed for admin addressability (TODO).
 pub fn scoped_name_for_principal(
     name: &str,
     principal: Option<&Principal>,

crates/openshell-server/src/grpc/provider.rs

@@ -175,10 +175,10 @@ pub(super) async fn create_provider_record(
 
     // Scope the DB name: if the provider has an owner label, prefix the name
     // with `{owner}/` so two users can have the same user-visible name.
-    if let Some(metadata) = provider.metadata.as_mut() {
-        if let Some(owner) = metadata.labels.get(OWNER_LABEL).cloned() {
-            metadata.name = scoped_name(&owner, &metadata.name);
-        }
+    if let Some(metadata) = provider.metadata.as_mut()
+        && let Some(owner) = metadata.labels.get(OWNER_LABEL).cloned()
+    {
+        metadata.name = scoped_name(&owner, &metadata.name);
     }
 
     // Generate UUID for database row and update metadata.id to match

crates/openshell-server/src/grpc/sandbox.rs

@@ -516,7 +516,7 @@ pub(super) async fn handle_detach_sandbox_provider(
         state.store.as_ref(),
         &request.provider_name,
         principal.as_ref(),
-        &admin_role_name(state),
+        admin_role_name(state),
     )
     .await
     .ok();