Skip to content

Commit 3d7a0fb

Browse files
authored
fix: clarify SPIRE warning message to avoid confusion (#505)
The existing warning 'SPIRE not detected for mTLS-enabled workload' is confusing because: 1. SPIRE may be running (via Helm) but not detected by this check 2. JWT-SVID authentication works fine despite this warning 3. The check only looks for socket volumes in the pod spec This commit clarifies that: - The check is specific to X.509-SVID based mTLS - JWT-SVID authentication is unaffected - The message explains what's actually being checked Fixes rossoctl/rossoctl#2361 Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
1 parent 5f4a8e3 commit 3d7a0fb

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

operator/internal/controller/agentruntime_controller.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -854,7 +854,11 @@ func (r *AgentRuntimeReconciler) evaluateMTLSReady(ctx context.Context, rt *agen
854854
r.Recorder.Eventf(rt, nil, corev1.EventTypeWarning, "SPIREUnavailable",
855855
"MTLSReadyCheck", msg)
856856
}
857-
logger.Info("SPIRE not detected for mTLS-enabled workload",
857+
// This check only verifies X.509-SVID volumes for mTLS certificate management.
858+
// This is expected with Helm-managed SPIRE deployments where volumes aren't
859+
// pre-injected. Other SPIRE features like SPIFFE auth (JWT-SVID) still work
860+
// as long as SPIRE is installed and the feature is enabled.
861+
logger.Info("SPIRE socket volumes not detected (X.509-SVID mTLS unavailable)",
858862
"workload", rt.Spec.TargetRef.Name, "mtlsMode", mtlsMode)
859863
}
860864
}

0 commit comments

Comments
 (0)