Problem
The two typecheck matrices disagree.
Makefile:
typecheck:
cd harness && pnpm exec tsc --noEmit
cd packages/k8s-sandbox && pnpm exec tsc --noEmit
cd packages/knative-server && pnpm exec tsc --noEmit
cd experiments && pnpm exec tsc --noEmit
.github/workflows/ci.yml (Typecheck step) runs the same four plus:
cd packages/sandbox-relay && pnpm exec tsc --noEmit
cd packages/ibac-stub && pnpm exec tsc --noEmit
Why it matters
make typecheck is what contributors and agents run as the local gate, and CLAUDE.md documents it as the typecheck command. A change touching packages/sandbox-relay or packages/ibac-stub can therefore be locally green and fail in CI — and the failure surfaces only after a push, which is the slowest possible feedback.
This bit during #188: the branch's local gate was reported as "typecheck clean" on the strength of make typecheck, and the two extra packages had to be run separately by review to establish that the seam change did not affect them (it did not — neither imports it).
Fix
Add the two missing packages to the Makefile target so the local gate matches CI. Better still, drive both from one list so they cannot drift again — e.g. a tsc --build project-references setup, or a small script both the Makefile and CI call.
Acceptance
Refs
Found by the whole-branch review of #188 (ST6).
Problem
The two typecheck matrices disagree.
Makefile:.github/workflows/ci.yml(Typecheck step) runs the same four plus:Why it matters
make typecheckis what contributors and agents run as the local gate, andCLAUDE.mddocuments it as the typecheck command. A change touchingpackages/sandbox-relayorpackages/ibac-stubcan therefore be locally green and fail in CI — and the failure surfaces only after a push, which is the slowest possible feedback.This bit during #188: the branch's local gate was reported as "typecheck clean" on the strength of
make typecheck, and the two extra packages had to be run separately by review to establish that the seam change did not affect them (it did not — neither imports it).Fix
Add the two missing packages to the
Makefiletarget so the local gate matches CI. Better still, drive both from one list so they cannot drift again — e.g. atsc --buildproject-references setup, or a small script both the Makefile and CI call.Acceptance
make typecheckcovers every package CI typechecks.Refs
Found by the whole-branch review of #188 (ST6).