From 6f6749ecbc94e0be8c73246f19b957b9601ba9b9 Mon Sep 17 00:00:00 2001 From: Tomasz Cielecki <249719+Cheesebaron@users.noreply.github.com> Date: Tue, 22 Apr 2025 13:00:02 +0200 Subject: [PATCH 1/3] Pass access token to carthage to prevent rate limiting --- .github/workflows/build.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index efbe7b0..725af26 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -56,6 +56,8 @@ jobs: mkdir -p artfifacts sh carthage.sh update --use-xcframeworks --platform iOS --log-path artifacts/carthage.log continue-on-error: true + env: + GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Disable SwiftLint in Nuke run: | @@ -64,6 +66,8 @@ jobs: - name: Build Nuke XCFramework run: sh carthage.sh build --use-xcframeworks --platform iOS --log-path artifacts/carthage.log + env: + GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Build NukeProxy XCFramework run: | From 2f87936ae070b7ec4aa8d953db856d6964fca08c Mon Sep 17 00:00:00 2001 From: Tomasz Cielecki <249719+Cheesebaron@users.noreply.github.com> Date: Tue, 22 Apr 2025 13:00:11 +0200 Subject: [PATCH 2/3] Pin actions versions --- .github/workflows/build.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 725af26..ffb61f9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -19,7 +19,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 with: fetch-depth: 0 @@ -31,7 +31,7 @@ jobs: name: Create Artifacts Directory - name: Setup .NET - uses: actions/setup-dotnet@v4 + uses: actions/setup-dotnet@67a3573c9a986a3f9c594539f4ab511d57bb3ce9 with: dotnet-version: ${{ env.dotnetVersion }} @@ -41,13 +41,13 @@ jobs: dotnetVersion: ${{ env.dotnetVersion }} - name: Install GitVersion - uses: gittools/actions/gitversion/setup@v3.0.0 + uses: gittools/actions/gitversion/setup@441c43ddefe9c8f5b8e8cee0257bcf06d518d2d3 with: versionSpec: '5.x' - name: Determine Version id: gitversion - uses: gittools/actions/gitversion/execute@v3.0.0 + uses: gittools/actions/gitversion/execute@441c43ddefe9c8f5b8e8cee0257bcf06d518d2d3 with: useConfigFile: true @@ -81,13 +81,13 @@ jobs: - name: Upload a Other Artifacts if: always() - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 with: name: Other path: 'artifacts/**/*' - name: Upload a NuGet Artifacts - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 with: name: NuGet path: '**/*.nupkg' From 16b20cf0c042888f64b85e2434f3f64400671d13 Mon Sep 17 00:00:00 2001 From: Tomasz Cielecki <249719+Cheesebaron@users.noreply.github.com> Date: Tue, 22 Apr 2025 13:07:17 +0200 Subject: [PATCH 3/3] No need to disable swiftlint in new Nuke --- .github/workflows/build.yml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ffb61f9..46f1525 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -59,16 +59,6 @@ jobs: env: GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Disable SwiftLint in Nuke - run: | - echo 'exit 0' > Carthage/Checkouts/Nuke/Scripts/lint.sh - echo 'exit 0' > Carthage/Checkouts/Nuke/Scripts/validate.sh - - - name: Build Nuke XCFramework - run: sh carthage.sh build --use-xcframeworks --platform iOS --log-path artifacts/carthage.log - env: - GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Build NukeProxy XCFramework run: | xcodebuild archive -sdk iphoneos -project NukeProxy.xcodeproj -scheme NukeProxy -configuration Release -archivePath Output/Output-iphoneos SKIP_INSTALL=NO