From dd0123d7862f4675bf049ac90cfa19edadf0cf10 Mon Sep 17 00:00:00 2001 From: Garrick Aden-Buie Date: Wed, 12 Nov 2025 08:18:45 -0500 Subject: [PATCH 1/3] tests(autocomplete): Ensure autocomplete has no chance for accidental collisions --- tests/testthat/test-auto-complete.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testthat/test-auto-complete.R b/tests/testthat/test-auto-complete.R index ef2cfccc8..a47aaa076 100644 --- a/tests/testthat/test-auto-complete.R +++ b/tests/testthat/test-auto-complete.R @@ -1,6 +1,6 @@ test_that("R auto complete finds runif vars", { - expect_equal(auto_complete_r("method not found"), list()) + expect_equal(auto_complete_r("this_variable_will_not_be_found"), list()) expect_equal(auto_complete_r("runif"), list( list("runif", TRUE) )) From 077196187ad0f78b1a397d98aac436159784ddfd Mon Sep 17 00:00:00 2001 From: Garrick Aden-Buie Date: Wed, 12 Nov 2025 09:10:13 -0500 Subject: [PATCH 2/3] ci: Use ubuntu-latest --- .github/workflows/R-CMD-check.yaml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml index 973a73536..19224bb56 100644 --- a/.github/workflows/R-CMD-check.yaml +++ b/.github/workflows/R-CMD-check.yaml @@ -27,12 +27,12 @@ jobs: config: - { os: macOS-latest, r: "release" } - { os: windows-latest, r: "release" } - - { os: ubuntu-20.04, r: "devel", http-user-agent: "release" } - - { os: ubuntu-20.04, r: "release" } - - { os: ubuntu-20.04, r: "oldrel-1" } - - { os: ubuntu-20.04, r: "oldrel-2" } - - { os: ubuntu-20.04, r: "oldrel-3" } - - { os: ubuntu-20.04, r: "oldrel-4" } + - { os: ubuntu-latest, r: "devel", http-user-agent: "release" } + - { os: ubuntu-latest, r: "release" } + - { os: ubuntu-latest, r: "oldrel-1" } + - { os: ubuntu-latest, r: "oldrel-2" } + - { os: ubuntu-latest, r: "oldrel-3" } + - { os: ubuntu-latest, r: "oldrel-4" } env: GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} @@ -71,7 +71,7 @@ jobs: - name: Schedule shinyapps.io deploy id: request-shinyapps-deploy - if: matrix.config.os == 'ubuntu-20.04' && matrix.config.r == 'release' + if: matrix.config.os == 'ubuntu-latest' && matrix.config.r == 'release' run: | echo "::set-output name=requested::true" From 42096b049df2fa080c26428646ad3572672a5550 Mon Sep 17 00:00:00 2001 From: Garrick Aden-Buie Date: Wed, 12 Nov 2025 09:37:52 -0500 Subject: [PATCH 3/3] chore: add news item --- NEWS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.md b/NEWS.md index a2ca912a5..4dcf14de8 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,7 @@ # learnr (development version) +- Fixed a test that was failing on CRAN's Fedora gcc environment. (#827) + - Added a new option, `tutorial.exercise.throttle`, to slow down successive exercise execution. This option should be set to the number of seconds a user will have to wait between performing code executions. The option defaults to 1 second to deter rapid code executions. To disable submission throttling, call `options(tutorial.exercise.throttle = 0)` within your setup chunk. (@internaut, #818) - Removed dependency on ellipsis (@olivroy, #809)