Wrong language with cache enabled

[enurist]

In S9Y 2.6.0 when cache is enabled and backend user is not logged in, the frontend is english but not in the configured language. Use user browser language is enabled. But with user logged in in backend, the frontend is displayed in the correct language.

And by the way, clear cache leads sometimes to new tab/page.

[onli]

Hi @enurist, thanks for the report. I imagine the parameters for frontend language detection are not part of the cache key and thus missed, and probably can be added.

And by the way, clear cache leads sometimes to new tab/page.

But that happen sometimes tend to be very hard to fix. If you see any consistent trigger of this, please let us know.

[fasterit]

The fix is trivial:

diff --git a/include/functions_entries.inc.php b/include/functions_entries.inc.php
index 7fb039dc..14918468 100644
--- a/include/functions_entries.inc.php
+++ b/include/functions_entries.inc.php
@@ -1086,7 +1086,7 @@ function serendipity_printEntries($entries, $extended = 0, $preview = false, $sm
     // Bypass cache for comment preview and submission feedback
     $bypass_cache = !empty($serendipity['POST']['preview']) || !empty($serendipity['POST']['submit']) || !empty($serendipity['GET']['csuccess']);
     if ($serendipity['useInternalCache']) {
-        $cache_key = md5(serialize($initial_args) . '||' . $serendipity['GET']['subpage'] . '||' .  serendipity_checkPermission('adminEntriesMaintainOthers'));
+        $cache_key = md5(serialize($initial_args) . '||' . $serendipity['GET']['subpage'] . '||' .  serendipity_checkPermission('adminEntriesMaintainOthers') . (!empty($serendipity['lang']) ? '||' . $serendipity['lang'] : ''));
 
         $cached = serendipity_getCacheItem($cache_key);
         if (!$bypass_cache && $cached && $cached !== false) {