diff --git a/distill/data_util/prep_yelp.py b/distill/data_util/prep_yelp.py index c12810e..50185ff 100644 --- a/distill/data_util/prep_yelp.py +++ b/distill/data_util/prep_yelp.py @@ -29,7 +29,26 @@ def generate_samples(self, mode, tmp_dir): yelp_dir = os.path.join(tmp_dir, "yelp_review_full_csv") if not tf.gfile.Exists(yelp_dir): with tarfile.open(download_path, "r:gz") as tar: - tar.extractall(tmp_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, tmp_dir) # Generate examples for doc, label in self.doc_generator(mode):