forked from gregjones/httpcache
-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathhttpcache_authorization_sharedcache_test.go
More file actions
612 lines (543 loc) · 17 KB
/
httpcache_authorization_sharedcache_test.go
File metadata and controls
612 lines (543 loc) · 17 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
//nolint:goconst // Test file with acceptable string duplication for readability
package httpcache
import (
"io"
"net/http"
"net/http/httptest"
"testing"
)
// TestAuthorizationPrivateCache tests that private caches CAN cache Authorization responses
// RFC 9111 Section 3.5: Private caches (browsers, API clients) can cache authenticated responses
func TestAuthorizationPrivateCache(t *testing.T) {
resetTest()
requestCount := 0
testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requestCount++
auth := r.Header.Get("Authorization")
if auth == "" {
w.WriteHeader(http.StatusUnauthorized)
w.Write([]byte("Unauthorized"))
return
}
// Response without special Cache-Control directives
w.Header().Set("Cache-Control", "max-age=3600")
w.Write([]byte("Private response for: " + auth))
}))
defer testServer.Close()
// Create private cache (default)
tp := NewMemoryCacheTransport()
tp.MarkCachedResponses = true
// IsPublicCache is false by default
client := tp.Client()
// First request with Authorization
req1, err := http.NewRequest("GET", testServer.URL, nil)
if err != nil {
t.Fatal(err)
}
req1.Header.Set("Authorization", "Bearer token1")
resp1, err := client.Do(req1)
if err != nil {
t.Fatal(err)
}
if resp1.StatusCode != http.StatusOK {
t.Fatalf("Expected status 200, got %d", resp1.StatusCode)
}
io.ReadAll(resp1.Body)
resp1.Body.Close()
if requestCount != 1 {
t.Fatalf("Expected 1 request, got %d", requestCount)
}
// Second request with same Authorization (should be cached in private cache)
req2, err := http.NewRequest("GET", testServer.URL, nil)
if err != nil {
t.Fatal(err)
}
req2.Header.Set("Authorization", "Bearer token1")
resp2, err := client.Do(req2)
if err != nil {
t.Fatal(err)
}
if resp2.StatusCode != http.StatusOK {
t.Fatalf("Expected status 200, got %d", resp2.StatusCode)
}
io.ReadAll(resp2.Body)
resp2.Body.Close()
if requestCount != 1 {
t.Fatalf("Expected 1 request (second should be cached), got %d", requestCount)
}
// Verify response was served from cache
if resp2.Header.Get(XFromCache) != "1" {
t.Fatal("Expected response to be served from cache in private cache mode")
}
}
// TestAuthorizationSharedCacheNoDirective tests that shared caches MUST NOT cache
// Authorization responses without public/must-revalidate/s-maxage directives
// RFC 9111 Section 3.5
func TestAuthorizationSharedCacheNoDirective(t *testing.T) {
resetTest()
requestCount := 0
testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requestCount++
auth := r.Header.Get("Authorization")
if auth == "" {
w.WriteHeader(http.StatusUnauthorized)
w.Write([]byte("Unauthorized"))
return
}
// Response WITHOUT public/must-revalidate/s-maxage
w.Header().Set("Cache-Control", "max-age=3600")
w.Write([]byte("Response for: " + auth))
}))
defer testServer.Close()
// Create shared/public cache
tp := NewMemoryCacheTransport()
tp.MarkCachedResponses = true
tp.IsPublicCache = true // Enable shared cache mode
client := tp.Client()
// First request with Authorization
req1, err := http.NewRequest("GET", testServer.URL, nil)
if err != nil {
t.Fatal(err)
}
req1.Header.Set("Authorization", "Bearer token1")
resp1, err := client.Do(req1)
if err != nil {
t.Fatal(err)
}
if resp1.StatusCode != http.StatusOK {
t.Fatalf("Expected status 200, got %d", resp1.StatusCode)
}
io.ReadAll(resp1.Body)
resp1.Body.Close()
if requestCount != 1 {
t.Fatalf("Expected 1 request, got %d", requestCount)
}
// Second request with same Authorization
// Should NOT be cached (shared cache + no public/must-revalidate/s-maxage)
req2, err := http.NewRequest("GET", testServer.URL, nil)
if err != nil {
t.Fatal(err)
}
req2.Header.Set("Authorization", "Bearer token1")
resp2, err := client.Do(req2)
if err != nil {
t.Fatal(err)
}
if resp2.StatusCode != http.StatusOK {
t.Fatalf("Expected status 200, got %d", resp2.StatusCode)
}
io.ReadAll(resp2.Body)
resp2.Body.Close()
if requestCount != 2 {
t.Fatalf("Expected 2 requests (should NOT be cached), got %d", requestCount)
}
// Verify response was NOT served from cache
if resp2.Header.Get(XFromCache) == "1" {
t.Fatal("Expected response NOT to be cached in shared cache without public/must-revalidate/s-maxage")
}
}
// TestAuthorizationSharedCacheWithPublic tests that shared caches CAN cache
// Authorization responses when Cache-Control: public is present
// RFC 9111 Section 3.5
func TestAuthorizationSharedCacheWithPublic(t *testing.T) {
resetTest()
requestCount := 0
testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requestCount++
auth := r.Header.Get("Authorization")
if auth == "" {
w.WriteHeader(http.StatusUnauthorized)
w.Write([]byte("Unauthorized"))
return
}
// Response WITH public directive
w.Header().Set("Cache-Control", "public, max-age=3600")
w.Write([]byte("Public response for: " + auth))
}))
defer testServer.Close()
// Create shared/public cache
tp := NewMemoryCacheTransport()
tp.MarkCachedResponses = true
tp.IsPublicCache = true // Enable shared cache mode
client := tp.Client()
// First request with Authorization
req1, err := http.NewRequest("GET", testServer.URL, nil)
if err != nil {
t.Fatal(err)
}
req1.Header.Set("Authorization", "Bearer token1")
resp1, err := client.Do(req1)
if err != nil {
t.Fatal(err)
}
if resp1.StatusCode != http.StatusOK {
t.Fatalf("Expected status 200, got %d", resp1.StatusCode)
}
io.ReadAll(resp1.Body)
resp1.Body.Close()
if requestCount != 1 {
t.Fatalf("Expected 1 request, got %d", requestCount)
}
// Second request with same Authorization
// Should be cached (shared cache + public directive)
req2, err := http.NewRequest("GET", testServer.URL, nil)
if err != nil {
t.Fatal(err)
}
req2.Header.Set("Authorization", "Bearer token1")
resp2, err := client.Do(req2)
if err != nil {
t.Fatal(err)
}
if resp2.StatusCode != http.StatusOK {
t.Fatalf("Expected status 200, got %d", resp2.StatusCode)
}
io.ReadAll(resp2.Body)
resp2.Body.Close()
if requestCount != 1 {
t.Fatalf("Expected 1 request (second should be cached with public), got %d", requestCount)
}
// Verify response was served from cache
if resp2.Header.Get(XFromCache) != "1" {
t.Fatal("Expected response to be cached in shared cache with public directive")
}
}
// TestAuthorizationSharedCacheWithMustRevalidate tests that shared caches CAN cache
// Authorization responses when Cache-Control: must-revalidate is present
// RFC 9111 Section 3.5
func TestAuthorizationSharedCacheWithMustRevalidate(t *testing.T) {
resetTest()
requestCount := 0
testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requestCount++
auth := r.Header.Get("Authorization")
if auth == "" {
w.WriteHeader(http.StatusUnauthorized)
w.Write([]byte("Unauthorized"))
return
}
// Response WITH must-revalidate directive
w.Header().Set("Cache-Control", "must-revalidate, max-age=3600")
w.Write([]byte("Must-revalidate response for: " + auth))
}))
defer testServer.Close()
// Create shared/public cache
tp := NewMemoryCacheTransport()
tp.MarkCachedResponses = true
tp.IsPublicCache = true // Enable shared cache mode
client := tp.Client()
// First request with Authorization
req1, err := http.NewRequest("GET", testServer.URL, nil)
if err != nil {
t.Fatal(err)
}
req1.Header.Set("Authorization", "Bearer token1")
resp1, err := client.Do(req1)
if err != nil {
t.Fatal(err)
}
if resp1.StatusCode != http.StatusOK {
t.Fatalf("Expected status 200, got %d", resp1.StatusCode)
}
io.ReadAll(resp1.Body)
resp1.Body.Close()
if requestCount != 1 {
t.Fatalf("Expected 1 request, got %d", requestCount)
}
// Second request with same Authorization
// Should be cached (shared cache + must-revalidate directive)
req2, err := http.NewRequest("GET", testServer.URL, nil)
if err != nil {
t.Fatal(err)
}
req2.Header.Set("Authorization", "Bearer token1")
resp2, err := client.Do(req2)
if err != nil {
t.Fatal(err)
}
if resp2.StatusCode != http.StatusOK {
t.Fatalf("Expected status 200, got %d", resp2.StatusCode)
}
io.ReadAll(resp2.Body)
resp2.Body.Close()
if requestCount != 1 {
t.Fatalf("Expected 1 request (second should be cached with must-revalidate), got %d", requestCount)
}
// Verify response was served from cache
if resp2.Header.Get(XFromCache) != "1" {
t.Fatal("Expected response to be cached in shared cache with must-revalidate directive")
}
}
// TestAuthorizationSharedCacheWithSMaxAge tests that shared caches CAN cache
// Authorization responses when Cache-Control: s-maxage is present
// RFC 9111 Section 3.5
func TestAuthorizationSharedCacheWithSMaxAge(t *testing.T) {
resetTest()
requestCount := 0
testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requestCount++
auth := r.Header.Get("Authorization")
if auth == "" {
w.WriteHeader(http.StatusUnauthorized)
w.Write([]byte("Unauthorized"))
return
}
// Response WITH s-maxage directive
w.Header().Set("Cache-Control", "s-maxage=3600, max-age=1800")
w.Write([]byte("S-maxage response for: " + auth))
}))
defer testServer.Close()
// Create shared/public cache
tp := NewMemoryCacheTransport()
tp.MarkCachedResponses = true
tp.IsPublicCache = true // Enable shared cache mode
client := tp.Client()
// First request with Authorization
req1, err := http.NewRequest("GET", testServer.URL, nil)
if err != nil {
t.Fatal(err)
}
req1.Header.Set("Authorization", "Bearer token1")
resp1, err := client.Do(req1)
if err != nil {
t.Fatal(err)
}
if resp1.StatusCode != http.StatusOK {
t.Fatalf("Expected status 200, got %d", resp1.StatusCode)
}
io.ReadAll(resp1.Body)
resp1.Body.Close()
if requestCount != 1 {
t.Fatalf("Expected 1 request, got %d", requestCount)
}
// Second request with same Authorization
// Should be cached (shared cache + s-maxage directive)
req2, err := http.NewRequest("GET", testServer.URL, nil)
if err != nil {
t.Fatal(err)
}
req2.Header.Set("Authorization", "Bearer token1")
resp2, err := client.Do(req2)
if err != nil {
t.Fatal(err)
}
if resp2.StatusCode != http.StatusOK {
t.Fatalf("Expected status 200, got %d", resp2.StatusCode)
}
io.ReadAll(resp2.Body)
resp2.Body.Close()
if requestCount != 1 {
t.Fatalf("Expected 1 request (second should be cached with s-maxage), got %d", requestCount)
}
// Verify response was served from cache
if resp2.Header.Get(XFromCache) != "1" {
t.Fatal("Expected response to be cached in shared cache with s-maxage directive")
}
}
// TestAuthorizationSharedCacheMultipleDirectives tests combinations of directives
func TestAuthorizationSharedCacheMultipleDirectives(t *testing.T) {
tests := []struct {
name string
cacheControl string
shouldCache bool
isPublicCache bool
}{
{
name: "private_cache_no_directive",
cacheControl: "max-age=3600",
shouldCache: true,
isPublicCache: false,
},
{
name: "shared_cache_no_directive",
cacheControl: "max-age=3600",
shouldCache: false,
isPublicCache: true,
},
{
name: "shared_cache_with_public",
cacheControl: "public, max-age=3600",
shouldCache: true,
isPublicCache: true,
},
{
name: "shared_cache_with_must_revalidate",
cacheControl: "must-revalidate, max-age=3600",
shouldCache: true,
isPublicCache: true,
},
{
name: "shared_cache_with_s_maxage",
cacheControl: "s-maxage=3600, max-age=1800",
shouldCache: true,
isPublicCache: true,
},
{
name: "shared_cache_public_and_must_revalidate",
cacheControl: "public, must-revalidate, max-age=3600",
shouldCache: true,
isPublicCache: true,
},
{
name: "shared_cache_all_three_directives",
cacheControl: "public, must-revalidate, s-maxage=3600, max-age=1800",
shouldCache: true,
isPublicCache: true,
},
{
name: "private_cache_with_public",
cacheControl: "public, max-age=3600",
shouldCache: true,
isPublicCache: false,
},
{
name: "shared_cache_with_no_store",
cacheControl: "no-store",
shouldCache: false,
isPublicCache: true,
},
{
name: "shared_cache_public_with_no_store",
cacheControl: "public, no-store",
shouldCache: false,
isPublicCache: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
resetTest()
requestCount := 0
testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requestCount++
w.Header().Set("Cache-Control", tt.cacheControl)
w.Write([]byte("Response"))
}))
defer testServer.Close()
tp := NewMemoryCacheTransport()
tp.MarkCachedResponses = true
tp.IsPublicCache = tt.isPublicCache
client := tp.Client()
// First request with Authorization
req1, _ := http.NewRequest("GET", testServer.URL, nil)
req1.Header.Set("Authorization", "Bearer token1")
resp1, _ := client.Do(req1)
io.ReadAll(resp1.Body)
resp1.Body.Close()
// Second request with same Authorization
req2, _ := http.NewRequest("GET", testServer.URL, nil)
req2.Header.Set("Authorization", "Bearer token1")
resp2, _ := client.Do(req2)
io.ReadAll(resp2.Body)
resp2.Body.Close()
expectedRequests := 2
if tt.shouldCache {
expectedRequests = 1
}
if requestCount != expectedRequests {
t.Errorf("Expected %d requests, got %d (shouldCache=%v)", expectedRequests, requestCount, tt.shouldCache)
}
cacheHeaderExpected := "1"
if !tt.shouldCache {
cacheHeaderExpected = ""
}
if resp2.Header.Get(XFromCache) != cacheHeaderExpected {
t.Errorf("Expected X-From-Cache=%q, got %q", cacheHeaderExpected, resp2.Header.Get(XFromCache))
}
})
}
}
// TestAuthorizationWithNoAuthHeader tests that responses without Authorization header
// are cached normally in both private and shared caches
func TestAuthorizationWithNoAuthHeader(t *testing.T) {
tests := []struct {
name string
isPublicCache bool
}{
{
name: "private_cache",
isPublicCache: false,
},
{
name: "shared_cache",
isPublicCache: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
resetTest()
requestCount := 0
testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requestCount++
w.Header().Set("Cache-Control", "max-age=3600")
w.Write([]byte("Public response"))
}))
defer testServer.Close()
tp := NewMemoryCacheTransport()
tp.MarkCachedResponses = true
tp.IsPublicCache = tt.isPublicCache
client := tp.Client()
// First request without Authorization header
req1, _ := http.NewRequest("GET", testServer.URL, nil)
resp1, _ := client.Do(req1)
io.ReadAll(resp1.Body)
resp1.Body.Close()
// Second request without Authorization header
// Should be cached in both private and shared caches
req2, _ := http.NewRequest("GET", testServer.URL, nil)
resp2, _ := client.Do(req2)
io.ReadAll(resp2.Body)
resp2.Body.Close()
if requestCount != 1 {
t.Errorf("Expected 1 request (should be cached), got %d", requestCount)
}
if resp2.Header.Get(XFromCache) != "1" {
t.Error("Expected response to be cached when no Authorization header present")
}
})
}
}
// TestAuthorizationSharedCacheWithCacheKeyHeaders tests that Authorization header
// in CacheKeyHeaders creates separate cache entries per token in shared cache
func TestAuthorizationSharedCacheWithCacheKeyHeaders(t *testing.T) {
resetTest()
requestCount := 0
testServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
requestCount++
auth := r.Header.Get("Authorization")
// Response with public directive to allow shared cache
w.Header().Set("Cache-Control", "public, max-age=3600")
w.Write([]byte("Response for: " + auth))
}))
defer testServer.Close()
// Create shared cache with CacheKeyHeaders
tp := NewMemoryCacheTransport()
tp.MarkCachedResponses = true
tp.IsPublicCache = true // Shared cache
tp.CacheKeyHeaders = []string{"Authorization"}
client := tp.Client()
// Request 1: token1
req1, _ := http.NewRequest("GET", testServer.URL, nil)
req1.Header.Set("Authorization", "Bearer token1")
resp1, _ := client.Do(req1)
io.ReadAll(resp1.Body)
resp1.Body.Close()
// Request 2: token2 (different token, should NOT use cache)
req2, _ := http.NewRequest("GET", testServer.URL, nil)
req2.Header.Set("Authorization", "Bearer token2")
resp2, _ := client.Do(req2)
io.ReadAll(resp2.Body)
resp2.Body.Close()
// Request 3: token1 (same as req1, should use cache)
req3, _ := http.NewRequest("GET", testServer.URL, nil)
req3.Header.Set("Authorization", "Bearer token1")
resp3, _ := client.Do(req3)
io.ReadAll(resp3.Body)
resp3.Body.Close()
if requestCount != 2 {
t.Fatalf("Expected 2 requests (req1 and req2, req3 cached), got %d", requestCount)
}
// Verify req3 was served from cache
if resp3.Header.Get(XFromCache) != "1" {
t.Fatal("Expected response to be cached with CacheKeyHeaders in shared cache")
}
}