Feature Request - Show Password

[w0anm]

It would be nice to have a "Show Password" in the Find Account --> menu.
I sometimes connect the PasswordPump directly to a USB chanrger (Power Supply Connection Only) and would be nice to have the ability to view the password credential.

I'll look into seeing if I can make this change.

[seawarrior181]

Hi Chirs. Are you talking about the master password or the pw associated with a set of credentials? If the latter, you can see the password by going to Edit Credentials. Find Account-->Edit Credentials-->Edit Password. If the former, the issue you'll run into (when trying to add any new feature) is the program space. When you consume too much program space it's not always apparent until flaky defects start to occur. This is why I think it eventually needs to go to the ItsyBitsy or some such. I have a list of new features I'd like to have implemented. Dan

…

On May 11, 2019 at 11:52 AM Christopher Kovacs ***@***.***> wrote: It would be nice to have a "Show Password" in the Find Account --> menu. I sometimes connect the PasswordPump directly to a USB chanrger (Power Supply Connection Only) and would be nice to have the ability to view the password credential. I'll look into seeing if I can make this change. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub #2 , or mute the thread https://github.com/notifications/unsubscribe-auth/AEUHQBERLSHF2ND5MLR23CTPU3TVDANCNFSM4HMINTBA .

[w0anm]

Hi Dan, I know that you can see the password if you edit the credentials. I was looking for showing the password in the directory above rather then getting into the edit mode. I have modified the code, but truly a hack since I am not that familiar with your code. I've added a "show password" after selecting the account in the "Find Account". I added the selection "Show Password" before "Edit Creds". When you short click on "Show Password" it displays the password on line 2. Seems to work great. It does not check to see if the "Password ON" flag is set however. I wanted to keep the code changes to a minimum. I've attached the code if your interested. It didn't loose too much space, but like you said, you're at the tipping point. Thanks for all your support. Chris ============================ Diffs: 552c558 < "Show Paswrd O ", // determines if passwords are displayed or not ---

"Show Psswrd O

", // determines if passwords are displayed or not 576c582 < #define SEND_MENU_ELEMENTS 8 // number of selections in the send creds menu ---

#define SEND_MENU_ELEMENTS

7 // number of selections in the send creds menu 582d587 < "Show Password", 592,594c597,598 < #define SHOW_PASSWORD 5 < #define EDIT_ACCOUNT 6 < #define DELETE_ACCOUNT 7 ---

#define EDIT_ACCOUNT 5 #define DELETE_ACCOUNT 6

596c600 < #define EDIT_MENU_NUMBER 3 ---

#define EDIT_MENU_NUMBER 2

788a793,796

// pullup pinMode(ROTARY_PIN1, INPUT_PULLUP); pinMode(ROTARY_PIN2, INPUT_PULLUP);

791,796d798 < < // pullup for encoder < pinMode(ROTARY_PIN1, INPUT_PULLUP); < pinMode(ROTARY_PIN2, INPUT_PULLUP); < < 1227,1230d1228 < break; < case SHOW_PASSWORD: // Show the password < readPassFromEEProm(acctPosition, password); < DisplayLine2(password);

…

On Sat, May 11, 2019, 11:15 Dan Murphy ***@***.***> wrote: Hi Chirs. Are you talking about the master password or the pw associated with a set of credentials? If the latter, you can see the password by going to Edit Credentials. Find Account-->Edit Credentials-->Edit Password. If the former, the issue you'll run into (when trying to add any new feature) is the program space. When you consume too much program space it's not always apparent until flaky defects start to occur. This is why I think it eventually needs to go to the ItsyBitsy or some such. I have a list of new features I'd like to have implemented. Dan > On May 11, 2019 at 11:52 AM Christopher Kovacs ***@***.***> wrote: > > > It would be nice to have a "Show Password" in the Find Account --> menu. > I sometimes connect the PasswordPump directly to a USB chanrger (Power Supply Connection Only) and would be nice to have the ability to view the password credential. > > I'll look into seeing if I can make this change. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub #2 , or mute the thread https://github.com/notifications/unsubscribe-auth/AEUHQBERLSHF2ND5MLR23CTPU3TVDANCNFSM4HMINTBA . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF2TB3TVTTYMGJKNHPPBZODPU3WLDANCNFSM4HMINTBA> .

[seawarrior181]

Chris, that's awesome! Modifying that code if you're not the person that wrote it definitely requires some skills; it's hard to understand how control is flowing through the program I think because it's so event driven. Nice work. I still have to get the first changes you made to the .ino and the .py programs incorporated and uploaded. I'm in the middle of a balancing robot project so time is tight (I have a full time job and 5 kids). I am surprised that you were able to add the feature given how tight the program space is right now. I've been battling against 'unexpected behavior' whenever I change pretty much anything at this point. Take care. Dan

…

On May 11, 2019 at 10:59 PM Christopher Kovacs ***@***.***> wrote: Hi Dan, I know that you can see the password if you edit the credentials. I was looking for showing the password in the directory above rather then getting into the edit mode. I have modified the code, but truly a hack since I am not that familiar with your code. I've added a "show password" after selecting the account in the "Find Account". I added the selection "Show Password" before "Edit Creds". When you short click on "Show Password" it displays the password on line 2. Seems to work great. It does not check to see if the "Password ON" flag is set however. I wanted to keep the code changes to a minimum. I've attached the code if your interested. It didn't loose too much space, but like you said, you're at the tipping point. Thanks for all your support. Chris ============================ Diffs: 552c558 < "Show Paswrd O ", // determines if passwords are displayed or not --- > "Show Psswrd O ", // determines if passwords are displayed or not 576c582 < #define SEND_MENU_ELEMENTS 8 // number of selections in the send creds menu --- > #define SEND_MENU_ELEMENTS 7 // number of selections in the send creds menu 582d587 < "Show Password", 592,594c597,598 < #define SHOW_PASSWORD 5 < #define EDIT_ACCOUNT 6 < #define DELETE_ACCOUNT 7 --- > #define EDIT_ACCOUNT 5 > #define DELETE_ACCOUNT 6 596c600 < #define EDIT_MENU_NUMBER 3 --- > #define EDIT_MENU_NUMBER 2 788a793,796 > // pullup > pinMode(ROTARY_PIN1, INPUT_PULLUP); > pinMode(ROTARY_PIN2, INPUT_PULLUP); > 791,796d798 < < // pullup for encoder < pinMode(ROTARY_PIN1, INPUT_PULLUP); < pinMode(ROTARY_PIN2, INPUT_PULLUP); < < 1227,1230d1228 < break; < case SHOW_PASSWORD: // Show the password < readPassFromEEProm(acctPosition, password); < DisplayLine2(password); On Sat, May 11, 2019, 11:15 Dan Murphy ***@***.***> wrote: > Hi Chirs. > > > Are you talking about the master password or the pw associated with a set > of credentials? If the latter, you can see the password by going to Edit > Credentials. Find Account-->Edit Credentials-->Edit Password. If the > former, the issue you'll run into (when trying to add any new feature) is > the program space. When you consume too much program space it's not always > apparent until flaky defects start to occur. This is why I think it > eventually needs to go to the ItsyBitsy or some such. I have a list of new > features I'd like to have implemented. > > > Dan > > > On May 11, 2019 at 11:52 AM Christopher Kovacs ***@***.***> > wrote: > > > > > > It would be nice to have a "Show Password" in the Find Account --> menu. > > I sometimes connect the PasswordPump directly to a USB chanrger (Power > Supply Connection Only) and would be nice to have the ability to view the > password credential. > > > > I'll look into seeing if I can make this change. > > > > — > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly, view it on GitHub > #2 , or mute the > thread > https://github.com/notifications/unsubscribe-auth/AEUHQBERLSHF2ND5MLR23CTPU3TVDANCNFSM4HMINTBA > . > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#2 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AF2TB3TVTTYMGJKNHPPBZODPU3WLDANCNFSM4HMINTBA> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub #2 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AEUHQBHECL57ASDWVOKA6ZDPU6BXLANCNFSM4HMINTBA .