PUT instead of DELETE request in the web API when removing the selection of documents

[milcent]

The DELETE request was not working to remove documents selection, with code 400. After a looooong period trying and thinking the json payload was wrong, I realized that, to remove a bookmark, the method was PUT, same as to add. So I tried PUT to remove selection and it worked!
Then I went to the web api docs page to propose a fix and a pull request but it went directly to accept my changes.
@lfcnassif, can you confirm this is the right request method to be used in this case? If not, please revert to the way it was before and accept my appologies.
Cheers,
Milcent

[wladimirleite]

Thanks @milcent!
Taking a quick look at the source code below, the correct request method is PUT, as you figured out.
As far as know, there are no pull requests for Wiki changes...

IPED/iped-engine/src/main/java/iped/engine/webapi/Selection.java

Lines 60 to 73 in eb8ac7c

	@ApiOperation(value = "Remove documents from selection")
	@PUT
	@Path("remove")
	@Consumes(MediaType.APPLICATION_JSON)
	public Response remove(@ApiParam(required = true) DocIDJSON[] docs) {
	IMultiBookmarks mm = Sources.multiSource.getMultiBookmarks();
	for (DocIDJSON d : docs) {
	mm.setChecked(false, new ItemId(Sources.sourceStringToInt.get(d.getSource()), d.getId()));
	}
	mm.saveState();
	return Response.ok().build();
	}
	}